NodeBB anti spam

bentael

So, I don't know if you want to plumb through the req object, or maybe implement the filter on a higher level, maybe at the POST /api/{route} handler

julian

Seems legit.

Topic.post and Topic.reply are both standalone functions, but to follow DRY, Topic.post calls Topic.reply
Topic.reply calls Posts.create

So I believe putting a hook in at the Posts.create level (here, as the first waterfall function) would be easiest.

I suggest filter:posts.check or filter:posts.validate as a name. filter:posts.save is already there, but the post creation process has already begun, so it is used mostly for munging data after it is destined to enter the database.

bentael

@julian ok, Post.create sounds like a good place, but can I guarantee that the req object is going to be plumbed in from all the paths?

julian

Hm... since posting is done via web sockets, we don't have the same data we would have in req... would have to example the socket data and see what we have to work with...

bentael

ok i'll investigate and post back

<baris>

I don't think we should put it in Posts.create as that is the internal function used by importers as well, Topics.reply seems like a better place as it is the one that is called by users and Topics.post calls that too.

bentael

okay.png

julian

Haha good thing we have @baris watching out for the wrong things I say

bentael

https://github.com/akhoury/nodebb-plugin-spam-be-gone updated, but blocked by https://github.com/designcreateplay/NodeBB/pull/1443

julian

@bentael Really glad to see the evolution of NodeBB's first anti-spam plugin!!