Meta Description Tag Missing in 1.13.1

damian

Users post to my site and then share those posts to Facebook. After upgrading from 1.12.2 to 1.13.1 I no longer see proper description or og:description tags in the head. Instead, the posts shared to facebook include a description that reports that Javascript is disabled.

I'm not sure where to look in the code to try to find what might be affecting the change and I'm unsure if this is something specific to me.

Both my stage and prod forums have been upgraded to the 1.13.1 and then I downgraded stage. So both are running the same DB schema.

Here's the head section from my staging site which I downgraded to 1.12.2

<!DOCTYPE html>
<html lang="en-US" data-dir="ltr" style="direction: ltr;"  >
<head>
	<title>Review: 2019-05-04- The Civic Theater - New Orleans, LA | Spaffnerds: Of Nerds, By Nerds, and For Nerds</title>
	<meta name="viewport" content="width&#x3D;device-width, initial-scale&#x3D;1.0" />
	<meta name="content-type" content="text/html; charset=UTF-8" />
	<meta name="apple-mobile-web-app-capable" content="yes" />
	<meta name="mobile-web-app-capable" content="yes" />
	<meta property="og:site_name" content="Spaffnerds" />
	<meta name="msapplication-badge" content="frequency=30; polling-uri=https://forum.stage.spaffnerds.com/sitemap.xml" />
	<meta name="keywords" content="Spafford,Jam Band,Music,Funk,Soul,Rock" />
	<meta name="msapplication-square150x150logo" content="/assets/uploads/system/site-logo.png" />
	<meta name="title" content="Review: 2019-05-04- The Civic Theater - New Orleans, LA" />
	<meta name="description" content="Setlist, Attendance, and Recordings for: 2019-05-04 - The Civic Theater - New Orleans, LA After three weeks of Spaffnerds tearing each other apart, consoling one another, and having emotions and rumors flying around like crazy, The day was finally here. W..." />
	<meta property="og:title" content="Review: 2019-05-04- The Civic Theater - New Orleans, LA" />
	<meta property="og:description" content="Setlist, Attendance, and Recordings for: 2019-05-04 - The Civic Theater - New Orleans, LA After three weeks of Spaffnerds tearing each other apart, consoling one another, and having emotions and rumors flying around like crazy, The day was finally here. W..." />
	<meta property="og:type" content="article" />
	<meta property="article:published_time" content="2019-05-07T04:51:45.205Z" />
	<meta property="article:modified_time" content="2019-05-22T22:33:17.566Z" />
	<meta property="article:section" content="Reviews" />
	<meta property="og:image" content="https://i.imgur.com/KpG7iM6.png" />
	<meta property="og:image:url" content="https://i.imgur.com/KpG7iM6.png" />
	<meta property="og:image" content="https://i.imgur.com/Fqa89tW.png" />
	<meta property="og:image:url" content="https://i.imgur.com/Fqa89tW.png" />
	<meta property="og:url" content="https://forum.stage.spaffnerds.com/topic/757/review-2019-05-04-the-civic-theater-new-orleans-la" />

Here's the head section from my production site which I downgraded to 1.13.1

<!DOCTYPE html>
<html lang="en-US" data-dir="ltr" style="direction: ltr;"  >
<head>
	<title>Review: 2019-05-04- The Civic Theater - New Orleans, LA | Spaffnerds: Of Nerds, By Nerds, and For Nerds</title>
	<meta name="viewport" content="width&#x3D;device-width, initial-scale&#x3D;1.0" />
	<meta name="content-type" content="text/html; charset=UTF-8" />
	<meta name="apple-mobile-web-app-capable" content="yes" />
	<meta name="mobile-web-app-capable" content="yes" />
	<meta property="og:site_name" content="Spaffnerds" />
	<meta name="msapplication-badge" content="frequency=30; polling-uri=https://forum.spaffnerds.com/sitemap.xml" />
	<meta name="keywords" content="Spafford,Jam Band,Music,Funk,Soul,Rock" />
	<meta name="msapplication-square150x150logo" content="/assets/uploads/system/site-logo.png" />
	<meta name="title" content="Review: 2019-05-04- The Civic Theater - New Orleans, LA" />
	<meta name="description" />
	<meta property="og:title" content="Review: 2019-05-04- The Civic Theater - New Orleans, LA" />
	<meta property="og:description" />
	<meta property="og:type" content="article" />
	<meta property="article:published_time" content="2019-05-07T04:51:45.205Z" />
	<meta property="article:modified_time" content="2019-05-22T22:33:17.566Z" />
	<meta property="article:section" content="Reviews" />
	<meta property="og:image" content="https://i.imgur.com/Fqa89tW.png" />
	<meta property="og:image:url" content="https://i.imgur.com/Fqa89tW.png" />
	<meta property="og:url" content="https://forum.spaffnerds.com/topic/757/review-2019-05-04-the-civic-theater-new-orleans-la" />

damian

It looks like this commit may have introduced the issue.

https://github.com/NodeBB/NodeBB/commit/7b90863971bdee5958432e65ce037e580755e93d

I'll do some investigation and see if changing this fixes it.

<baris>

Thanks for reporting, I am working on a fix.

<baris>

https://github.com/NodeBB/NodeBB/commit/10989cccaa76c65c8788df17998af412fd732d30

damian

Thank you so much! I see this is packaged into the 1.13.2 release! Can't wait to try it out!

<baris>

This should be in 1.13.2 and up.