Login redirect and logout dont work after upgrade ?

<baris>

Broken due to breaking changes in login/logout functionality.

erkki70

Same issue with the Lavender theme

Any pointers to solve this issue very much appreciated, thanks!

Geferon

@baris May I ask what this breaking changes are and how to fix them in our own themes?

<baris>

@Geferon https://github.com/NodeBB/NodeBB/pull/6841

julian

Let me know if you can't resolve that in your theme... otherwise if it works, I'm sure @pichalite would appreciate a PR to material

Ne Ho

Could you guys please point me out what part I would need to change in material-theme by pichalite to refresh the menu after login/logout, I have changed the logout to POST route instead GET but not sure what part I should change for top menu refresh after logout for example.

Geferon

@Ne-Ho I believe I have managed to fix it in my custom fork of the Material theme:
https://github.com/geferon/nodebb-theme-material

So far it works well on my forum without the page not refreshing/etc

Geferon

@julian Actually, I asked to try and fix the material theme

Ne Ho

@Geferon

ty for he fix for navigation it works now

Now i face some other issues, for the chat part I am not sure if that's happening only by me or others have similar issues

After update the main navigation slide toggle seems to be buggy, I believe that's an css issue, on toogle it also moves the whole container content

issue with navigation toogle, you can see the arrow position next to website name

I believe the loading chats should not be there

And I have also a warning in my chrome console

[deprecated] Accessing benchpress (formerly known as templates.js) globally is deprecated. Use `require(["benchpress"], function (Benchpress) { ... })` instead
get @ app.js:24

Geferon

@Ne-Ho Okay, I do have the chat Issue, i'll try to fix it, but I don't have the navigation toggle issue? I mean, is the sidebar on the left not positioned correctly for you, or what exactly is the problem?

Ne Ho

@Geferon yes it is wrong positioned, it should be on the left side (left: 0) but you can see on my image that it is moved for about 10px to the right, also the navigation "hamburger" or arrow on the image is not well positioned ("tw-switch input").

And if you could also check if you have the same issue with chat rooms, if you open the chat room (https://github.com/geferon/nodebb-theme-material/blob/master/templates/partials/chats/message-window.tpl#L2) in full view in browser it seems that the scrollbar is not working here https://github.com/geferon/nodebb-theme-material/blob/master/templates/partials/chats/message-window.tpl#L56

Geferon

@Ne-Ho I'm on my way of fixing this issues, tho it's strange because I don't get the positioning of the sidebar as you do

Ne Ho

@Geferon I am not sure if I can share a link to my website, but if you visit my site you can play with the menu and you will see it. If the link is a problem we can remove it later this should just give you an idea what my issue is.

i have this issue since I uploaded your version, previous I had not this issue so if you have changed the css that would be helpfull

Cirkus Serveri Forum

We are an international CoD4 gaming community, join our forums or game servers and have fun

Cirkus Serveri Forum (forum.cirkus-serveri.com)

Geferon

@Ne-Ho Sidebar issue doesn't happen on your site either
weird

What browser are you using?

Ne Ho

@Geferon look at top left corner on the image what you have sent, the left arrow next to site name. It hapend on any browser, I will revert back the theme to compare it with yours. Thank you for solving the theme issues btw

Geferon

@Ne-Ho Oh you mean the arrow? Then I have fixed that in a internal version I have which I will publish in a few minutes.
I thought the spacing issue was https://i.imgur.com/Mz7ifwj.png
Like, the sidebar having empty space on the left

Ne Ho

@Geferon that spacing is also present

Geferon

@Ne-Ho Weird, can't see it in my end. I'm about to upload a new version, will tell you when and maybe it'll also fix it(?)

Geferon

@Ne-Ho Just updated the repo.
You should update the package manually, the nodebb plugins menu doesn't work for git repo updates.

Ne Ho

@Geferon thank you, now the style is also fine. there is 1 last part what I saw as bugged, when I open my chat in full view there is no scrollbar when there are more than X messages, and when there are enough messages my global widget positioned in Footer overlaps the chat messages