Composer-Defaults fails with latest master

[JJSagan]

Hi Devs,

Pulled the latest code today.
There seems to be an issue with composer-defaults failing at websockets line 128:

error: uncaughtException: Cannot read property 'children' of undefined
TypeError: Cannot read property 'children' of undefined
at /home/nodebb/www/nodebb/node_modules/nodebb-plugin-composer-default/websockets.js:128:73

Any idea what went wrong?

Here is the relevant piece of code from websockets.js:

const hasChildren = !!c.children.length;
				if (hasChildren) {
					c.disabledClass = true;
				} else if (c.parent) {
					cidToCategory[c.parent.cid].children = cidToCategory[c.parent.cid].children.filter(child => {
						return child.cid !== c.cid;
					});
				}

[julian]

What are you doing when the error shows up?

[JJSagan]

Hi @julian that's a tough one.
I have been trying to debug this issue before I posted but was unable to re-create the crash.
All I have is the logs to go with, unfortunately.
I posted in hope that this error may be related to something that was worked on in the past few days.
My apology for not being so helpful.
JJ.

[JJSagan]

Anyone ending here, the issue was observed by @baris and being discussed in this post:

Redactor crashes NodeBB

Hi Devs, It seems that Redactor may have an issue with the latest master. When opened, it crashes nodebb with the below. The issue can be reproduced, again a...

NodeBB Community (community.nodebb.org)