A couple of years ago there was also a lower adoption of html5 elements. Having one h1 tag per page is still a good Idea in general, but it is allowable to have one h1 tag per containing article tag as well. Since this theme does not seem to use tags like article and aside (that I've seen in my quick check) I agree that there should only be one h1 tag per page which contains the page title or headline. The theme structure is otherwise good, but could definitely use with some contextual revamping of quite a few divs.
persona child theme and v1.11.0
-
no matter what I try, I cant get my child theme to load correctly on v1.11.0.
none of my custom css or js are loaded after a rebuild.this is my build process, which worked just fine on v1.10.2
npm install git+https://git@github.com/sweetppro/nodebb-theme-sweetp ./nodebb build tpl ./nodebb build css ./nodebb build js ./nodebb stop ./nodebb start -
https://community.nodebb.org/topic/12952/1-11-0-breaking-changes/6 did you check the theme breaking changes?
-
thanks!
all good now.I hadn't noticed that the header.tpl template had been changed here:
https://github.com/NodeBB/nodebb-theme-persona/commit/90a1ba1eb1f5377c45c44656d3172389656c5a90
Suggested Topics
-
UNSOLVED Basic New Theme
Technical Support • • charles
Copyright © 2021 NodeBB | Contributors