upgrade from v1.10.2 to v1.11 crashing

[sweetp]

I have this crash happening after upgrading:
TypeError: Cannot read property 'cid' of null

everything was fine before the upgrade, Im using Postgres as my database. Any ideas on what might be the issue?

[sweetp]

it seems my custom theme is causing the crashing, but crashing still happens even after disabling and rebuilding the theme... Im not so sure that's the problem now

[baris]

What is the rest of the log?

[sweetp]

2018-11-29T11:51:11.547Z [3246] - error: uncaughtException: Cannot read property 'cid' of null
TypeError: Cannot read property 'cid' of null
    at categories.map.category (/root/NodeBB/src/categories/index.js:338:51)
    at Array.map (<anonymous>)
    at Object.Categories.getTree (/root/NodeBB/src/categories/index.js:338:26)
    at async.waterfall.data.title (/root/NodeBB/src/controllers/categories.js:30:22)
    at nextTask (/root/NodeBB/node_modules/async/dist/async.js:5324:14)
    at next (/root/NodeBB/node_modules/async/dist/async.js:5331:9)
    at /root/NodeBB/node_modules/async/dist/async.js:969:16
    at /root/NodeBB/node_modules/async/dist/async.js:473:16
    at next (/root/NodeBB/node_modules/async/dist/async.js:5329:29)
    at /root/NodeBB/node_modules/async/dist/async.js:969:16
    at /root/NodeBB/node_modules/async/dist/async.js:473:16
    at next (/root/NodeBB/node_modules/async/dist/async.js:5329:29)
    at /root/NodeBB/node_modules/async/dist/async.js:969:16
    at /root/NodeBB/src/categories/index.js:175:4
    at nextTask (/root/NodeBB/node_modules/async/dist/async.js:5324:14)
    at next (/root/NodeBB/node_modules/async/dist/async.js:5331:9) {"error":{},"stack":"TypeError: Cannot read property 'cid' of null\n    at categories.map.category (/root/NodeBB/src/categories/index.js:338:51)\n    at Array.map (<anonymous>)\n    at Object.Categories.getTree (/root/NodeBB/src/categories/index.js:338:26)\n    at async.waterfall.data.title (/root/NodeBB/src/controllers/categories.js:30:22)\n    at nextTask (/root/NodeBB/node_modules/async/dist/async.js:5324:14)\n    at next (/root/NodeBB/node_modules/async/dist/async.js:5331:9)\n    at /root/NodeBB/node_modules/async/dist/async.js:969:16\n    at /root/NodeBB/node_modules/async/dist/async.js:473:16\n    at next (/root/NodeBB/node_modules/async/dist/async.js:5329:29)\n    at /root/NodeBB/node_modules/async/dist/async.js:969:16\n    at /root/NodeBB/node_modules/async/dist/async.js:473:16\n    at next (/root/NodeBB/node_modules/async/dist/async.js:5329:29)\n    at /root/NodeBB/node_modules/async/dist/async.js:969:16\n    at /root/NodeBB/src/categories/index.js:175:4\n    at nextTask (/root/NodeBB/node_modules/async/dist/async.js:5324:14)\n    at next (/root/NodeBB/node_modules/async/dist/async.js:5331:9)","exception":true,"date":"Thu Nov 29 2018 11:51:11 GMT+0000 (UTC)","process":{"pid":3246,"uid":0,"gid":0,"cwd":"/root/NodeBB","execPath":"/usr/bin/node","version":"v8.12.0","argv":["/usr/bin/node","/root/NodeBB/app.js"],"memoryUsage":{"rss":150511616,"heapTotal":120307712,"heapUsed":87167784,"external":122200}},"os":{"loadavg":[0.88525390625,0.4326171875,0.248046875],"uptime":2095},"trace":[{"column":51,"file":"/root/NodeBB/src/categories/index.js","function":"categories.map.category","line":338,"method":"category","native":false},{"column":null,"file":null,"function":"Array.map","line":null,"method":"map","native":false},{"column":26,"file":"/root/NodeBB/src/categories/index.js","function":"Object.Categories.getTree","line":338,"method":"getTree","native":false},{"column":22,"file":"/root/NodeBB/src/controllers/categories.js","function":"async.waterfall.data.title","line":30,"method":"title","native":false},{"column":14,"file":"/root/NodeBB/node_modules/async/dist/async.js","function":"nextTask","line":5324,"method":null,"native":false},{"column":9,"file":"/root/NodeBB/node_modules/async/dist/async.js","function":"next","line":5331,"method":null,"native":false},{"column":16,"file":"/root/NodeBB/node_modules/async/dist/async.js","function":null,"line":969,"method":null,"native":false},{"column":16,"file":"/root/NodeBB/node_modules/async/dist/async.js","function":null,"line":473,"method":null,"native":false},{"column":29,"file":"/root/NodeBB/node_modules/async/dist/async.js","function":"next","line":5329,"method":null,"native":false},{"column":16,"file":"/root/NodeBB/node_modules/async/dist/async.js","function":null,"line":969,"method":null,"native":false},{"column":16,"file":"/root/NodeBB/node_modules/async/dist/async.js","function":null,"line":473,"method":null,"native":false},{"column":29,"file":"/root/NodeBB/node_modules/async/dist/async.js","function":"next","line":5329,"method":null,"native":false},{"column":16,"file":"/root/NodeBB/node_modules/async/dist/async.js","function":null,"line":969,"method":null,"native":false},{"column":4,"file":"/root/NodeBB/src/categories/index.js","function":null,"line":175,"method":null,"native":false},{"column":14,"file":"/root/NodeBB/node_modules/async/dist/async.js","function":"nextTask","line":5324,"method":null,"native":false},{"column":9,"file":"/root/NodeBB/node_modules/async/dist/async.js","function":"next","line":5331,"method":null,"native":false}]}
2018-11-29T11:51:11.548Z [3246] - error: Cannot read property 'cid' of null
TypeError: Cannot read property 'cid' of null
    at categories.map.category (/root/NodeBB/src/categories/index.js:338:51)
    at Array.map (<anonymous>)
    at Object.Categories.getTree (/root/NodeBB/src/categories/index.js:338:26)
    at async.waterfall.data.title (/root/NodeBB/src/controllers/categories.js:30:22)
    at nextTask (/root/NodeBB/node_modules/async/dist/async.js:5324:14)
    at next (/root/NodeBB/node_modules/async/dist/async.js:5331:9)
    at /root/NodeBB/node_modules/async/dist/async.js:969:16
    at /root/NodeBB/node_modules/async/dist/async.js:473:16
    at next (/root/NodeBB/node_modules/async/dist/async.js:5329:29)
    at /root/NodeBB/node_modules/async/dist/async.js:969:16
    at /root/NodeBB/node_modules/async/dist/async.js:473:16
    at next (/root/NodeBB/node_modules/async/dist/async.js:5329:29)
    at /root/NodeBB/node_modules/async/dist/async.js:969:16
    at /root/NodeBB/src/categories/index.js:175:4
    at nextTask (/root/NodeBB/node_modules/async/dist/async.js:5324:14)
    at next (/root/NodeBB/node_modules/async/dist/async.js:5331:9)
2018-11-29T11:51:11.549Z [3246] - info: [app] Shutdown (SIGTERM/SIGINT) Initialised.
2018-11-29T11:51:11.552Z [3246] - info: [app] Web server closed to connections.
[cluster] Child Process (3246) has exited (code: 1, signal: null)

[baris]

git pull to get this fix https://github.com/NodeBB/NodeBB/commit/29e9310aa5e42e8dec7e3b29fe8e5d9de99e80c4.

[sweetp]

now I get a different crash:

2018-11-29T13:55:11.935Z [3979] - error: Cannot read property 'numRecentReplies' of null
TypeError: Cannot read property 'numRecentReplies' of null
    at categoryData.filter.category (/root/NodeBB/src/categories/recentreplies.js:88:80)
    at Array.filter (<anonymous>)
    at /root/NodeBB/src/categories/recentreplies.js:88:43
    at nextTask (/root/NodeBB/node_modules/async/dist/async.js:5324:14)
    at Object.waterfall (/root/NodeBB/node_modules/async/dist/async.js:5334:5)
    at Object.Categories.getRecentTopicReplies (/root/NodeBB/src/categories/recentreplies.js:86:9)
    at async.waterfall.data.title (/root/NodeBB/src/controllers/categories.js:31:15)
    at nextTask (/root/NodeBB/node_modules/async/dist/async.js:5324:14)
    at next (/root/NodeBB/node_modules/async/dist/async.js:5331:9)
    at /root/NodeBB/node_modules/async/dist/async.js:969:16
    at /root/NodeBB/node_modules/async/dist/async.js:473:16
    at next (/root/NodeBB/node_modules/async/dist/async.js:5329:29)
    at /root/NodeBB/node_modules/async/dist/async.js:969:16
    at /root/NodeBB/node_modules/async/dist/async.js:473:16
    at next (/root/NodeBB/node_modules/async/dist/async.js:5329:29)
    at /root/NodeBB/node_modules/async/dist/async.js:969:16
2018-11-29T13:55:11.936Z [3979] - info: [app] Shutdown (SIGTERM/SIGINT) Initialised.
[cluster] Child Process (3979) has exited (code: 1, signal: null)

[sweetp]

I got it working, and created a pull request here:
https://github.com/NodeBB/NodeBB/pull/7029/commits/3e9d63b9a08221c3d010472a1f25e9d20498487e

[baris]

Inspect your category data, it seems you have some invalid data in there.