Solved recentreplies.js Error causing problems

[Tom_Rade]

@julian You're a real magician. This is crazy fast support. I'm absolutely stunned by NodeBB now. Not going to consider switching anymore because you fixed it. Thank you sooo much!

Could you post the commit-URL so I can edit it locally on my release-install?

[julian]

Yes, you can cherry-pick this sha to get it into your NodeBB

Edit: You just happened to catch me online at the same time, hah. The flag issue is also resolved from a couple days ago, so it wasn't done just now

[Tom_Rade]

@julian Alright, but if you made me aware of the commit/fix. And very fast.

I'll fix some horrible German translations (especially in the GDPR which is critical) as a favor. I hope Transifex gets merged soon (regarding: https://community.nodebb.org/topic/13269/missing-translation-string-user-watched_categories/).

You saved my 150k community from switching to phpBB

[PJ Legendre]

Hi, I'm getting a similar error message Cannot read property 'forEach' of undefined but in authentication.js:63:19. It started after I installed a couple of sso plugins: Facebook, Twitter, Discord, and Google. The cherry pick did not help me

[baris]

@PJ-Legendre please post the stack trace from logs/output.log

[PJ Legendre]

Thank you for getting back so quickly. Here it is:

NodeBB v1.10.2 Copyright (C) 2013-2014 NodeBB Inc.
This program comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to redistribute it under certain conditions.
For the full license, please visit: http://www.gnu.org/copyleft/gpl.html

Clustering enabled: Spinning up 1 process(es).

2018-11-16T15:34:42.545Z [6029] - ^[[32minfo^[[39m: Initializing NodeBB v1.10.2 https://forum.mydomain.com
2018-11-16T15:34:45.317Z [6029] - ^[[32minfo^[[39m: [socket.io] Restricting access to origin: https://forum.mydomain.com:*
2018-11-16T15:34:45.956Z [6029] - ^[[31merror^[[39m: [sso-discord] Cliend ID and Client Secret required (library.js:36)
2018-11-16T15:34:41.422Z [5991] - ^[[31merror^[[39m:  message=Cannot read property 'forEach' of undefined, stack=TypeError: Cannot read property 'forEach' of undefined
    at /home/myuser/nodebb/src/routes/authentication.js:63:19
    at nextTask (/home/myuser/nodebb/node_modules/async/dist/async.js:5324:14)
    at next (/home/myuser/nodebb/node_modules/async/dist/async.js:5331:9)
    at /home/myuser/nodebb/node_modules/async/dist/async.js:969:16
    at /home/myuser/nodebb/node_modules/async/dist/async.js:473:16
    at /home/myuser/nodebb/node_modules/async/dist/async.js:2521:9
    at /home/myuser/nodebb/node_modules/async/dist/async.js:473:16
    at replenish (/home/myuser/nodebb/node_modules/async/dist/async.js:1006:25)
    at iterateeCallback (/home/myuser/nodebb/node_modules/async/dist/async.js:995:17)
    at /home/myuser/nodebb/node_modules/async/dist/async.js:969:16
    at /home/myuser/nodebb/node_modules/async/dist/async.js:2518:13
    at Object.Facebook.getStrategy (/home/myuser/nodebb/node_modules/nodebb-plugin-sso-facebook/library.js:140:3)
    at /home/myuser/nodebb/node_modules/nodebb-plugin-sso-facebook/library.js:72:14
    at /home/myuser/nodebb/node_modules/nodebb-plugin-sso-facebook/library.js:65:4
    at /home/myuser/nodebb/src/meta/settings.js:14:3
    at /home/myuser/nodebb/src/database/mongo/hash.js:78:4
2018-11-16T15:34:41.426Z [5991] - ^[[32minfo^[[39m: [app] Shutdown (SIGTERM/SIGINT) Initialised.
2018-11-16T15:34:41.427Z [5991] - ^[[31merror^[[39m:  message=Not running, stack=Error: Not running
    at Server.<anonymous> (net.js:1517:12)
    at Server.g (events.js:292:16)
    at emitNone (events.js:91:20)
    at Server.emit (events.js:185:7)
    at emitCloseNT (net.js:1568:8)
    at _combinedTickCallback (internal/process/next_tick.js:77:11)
    at Immediate._tickCallback (internal/process/next_tick.js:104:9)
    at runCallback (timers.js:672:20)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate [as _immediateCallback] (timers.js:617:5)

[baris]

I added a check so nodebb doesn't crash here You possibly activated an sso plugin that is not using filter:auth.init properly. Which sso plugins do you have?

[PJ Legendre]

Thanks so much for the fix! I activated these plugins:

• https://github.com/julianlam/nodebb-plugin-sso-facebook
• https://github.com/julianlam/nodebb-plugin-sso-google
• https://github.com/julianlam/nodebb-plugin-sso-twitter
• https://github.com/NathanSMB/nodebb-plugin-sso-discord

I assume the culprit might be the discord one?

[baris]

Yes, it needs to be updated so it doesnt pass back undefined to hook callback.

[PJ Legendre]

I will notify the plugin's creator, thank you.