Database Backup
-
I wonder, wouldn't be a good thing to automatically backup the database when a schema change happened with the
./nodebb upgradescript? -
Ideally, yes, but I can't guarantee permissions on the redis database. For example, in default Ubuntu installs, the dump is located at /var/lib/redis, and has
-rw-rw----permissions, owned byredis:redis, so my unprivileged user won't be able to access it
-
Indeed, there is restricted permissions on redis dumb.
Would it be unsafe to include NodeBB user in Redis group?
-
Probably would be fine, but some may balk because it would allow a potentially compromised NodeBB app to read db dumps from other applications.
In any case, because it's not the default, it can't be in core, because it would be broken for 99% of the users
