Threaded views?

[julian]

@phenomlab v1.2.4 of the link-preview plugin should resolve this. You can remove the hardcoded 800px width now I think.

[phenomlab]

@julian There isn't any hardcoding in the link I added? Not sure what you mean.

[julian]

It looks like on sudonix there's an 800px width added via style tag that fixes the overflow. You can remove it if that was a temporary fix.

[baris]

@julian The overflow issue happened on this forum but the video tag doesn't embed now

[phenomlab]

@julian Yes, but I'm not using the link-preview plugin. I use my own

[julian]

@baris okay well when it decides to work it'll embed ok

[phenomlab]

New code released for the threaded views - available here

Threaded post support for NodeBB

Here’s a video of the threading code working on stock Harmony on NodeBB. However, it’s important to note that the timeline bar is removed and recreated. Ther...

Sudonix | A one-stop-shop for all your technology questions (sudonix.org)

Video here

[julian]

@phenomlab When a topic is threaded, what happens to post order? e.g. if I reply to one of the top branches, does my reply show up near the top?

The re-ordering issue (especially in the context of fully supporting infinite load and pagination) is what makes doing this in core hard.

[phenomlab]

@julian No. It's "threading" in the sense of readability, and not post order.

[phenomlab]

@julian said in Threaded views?:

The re-ordering issue (especially in the context of fully supporting infinite load and pagination) is what makes doing this in core hard.

Yes, I haven't attempted this yet. This would be a serious manipulation of the DOM elements too.

[julian]

@phenomlab Honestly it's really about scaling... it's easy to say "let's load all the posts and re-order them all", but what happens if you have a topic that is a million posts long?

[phenomlab]

@julian Exactly. It's just not feasible and would cause significant strain even with lazy loading. It's why I've opted for 2nd best, which is the "cosmetic" route meaning certain posts (for example, your own, and topic-owner) stand out.