Manually setting vote count for posts

razibal

I think I can sort of get what I need by using that hook and just displaying the adjusted vote count
hookData.posts.map( post => { post.votes = post.votes + post.importedVotes})

I didn't know that the category view only displays the vote count for the main post. Is there an option to use the total votes for the posts in the topic? My thinking is that if a user is sorting by 'Most Votes', it makes sense to use the cumulative votes.

<baris>

@razibal see this topic https://community.nodebb.org/post/95161 for a plugin that does that.

razibal

That will work perfectly. I'll create a custom topic field for the total imported votes and add them to the calculated votes.

Appreciate the help!

razibal

@baris This works, however the soring by votes still seems to be using the votes on the main post. Where is the logic for sorting handled?

<baris>

On category pages it's in handled by Categories.getTopicIds it uses a sorted set based on how the user wants the topics to be sorted. If you want to sort by votes it uses cid:<cid>:tids:votes the scores in there determine how they are sorted. In this case the scores don't have your imported values so that's why it doesn't work.

razibal

@baris, if we ignore my imported votes, should it be using the calculated/cumulative totals or are they still sorted by the votes on the main post?

<baris>

They are sorted by whatever score is set in that sorted set and that score is right now is the score of the main post. https://github.com/NodeBB/NodeBB/blob/master/src/posts/votes.js#L292

razibal

Apologies for all the questions, but I am trying to understand how simulated sorted sets work in MongoDB. In Redis, inserting an element into a sorted set is handled by the DB as it gets placed in the right ranking order based on the score. How does this work with MongoDB? Is the entire set recreated when a score changes or a new element needs to be added? I can lock down the voting on imported topics, but I do need to set the correct values in the cid:<cid>:tids:votes set on import.

<baris>

It works the same as redis in mongodb you just add an element with db.sortedSetAdd('someSet', 123, 'item1'); and when you retrieve it with db.getSortedSetRange('someSet', 0, -1) it will be in the correct order. It is handled by the _key, score compound index on the objects collection.

razibal

Cool, and I assume that adding an element that already exists is handled transparently ( score gets updated ). By the way, have you, or anyone else, tried nodeBB with tidis https://github.com/tidb-incubator/tidis

<baris>

@razibal said in Manually setting vote count for posts:

Cool, and I assume that adding an element that already exists is handled transparently ( score gets updated )

Yeah it just updates the score if it's already in the zset.

I haven't looked at tidis, to be honest we have enough database adapters to deal with already

razibal

@baris

@baris said in Manually setting vote count for posts:

I haven't looked at tidis, to be honest we have enough database adapters to deal with already

Understandable, only reason I brought it up is because it appears that all the adapters are essentially emulating Redis, and Tidis promises 100% protocol compatibility while addressing the negatives of Redis. I will admit using MongoDB as a Redis replacement has been a little bit frustrating for me because none of the collection structures look like what I would expect them to in MongoDB

razibal

I was able to set the imported vote count in the import script by adding
await db.sortedSetAdd(`cid:${topic.cid}:tids:votes`, post.importedVotes, post.tid) to the script

However, it doesn't look like there is any way to get 'Sort by Most Votes' (using all votes rather that just the main post votes) to work without modifying the updateTopicVoteCount function in the src/posts/votes.js module. It's going to need to sum all the votes in the topic and set that as the cid:${topicData.cid}:tids:votes value.

This is an example of a use case where being to override a core method or function would be really useful.

<baris>

You can probably use this hook to do the recalculation https://github.com/NodeBB/NodeBB/blob/master/src/posts/votes.js#L267

razibal

Thanks, that works perfectly. I'm handling the hook in my custom theme, but this probably needs to be in the https://community.nodebb.org/post/95161 plugin as well (without the importedVotes)

library.setTopicVotes = async function(hookData) {
    const topicData = await topics.getTopicFields(hookData.post.tid, ['cid', 'importedVotes']);
    const importedVotes = topicData.importedVotes || 0
    const voteData = await db.getSortedSetRangeByScoreWithScores(`tid:${hookData.post.tid}:posts:votes`, 0, -1, 1, '+inf');
    let allvotes = voteData.reduce((acc, cur) => acc + cur.score, 0);
    allvotes = allvotes + importedVotes
    await db.sortedSetAdd(`cid:${topicData.cid}:tids:votes`, allvotes, hookData.post.tid)
}