untranslated string in Harmony child theme

[sweetp]

I am using a custom Harmony child theme with NodeBB v3.1.2. I just noticed that one of the strings on the user settings page is untranslated:

How exactly do I go about getting the translated string to show?

[sweetp]

it looks like this function in Library.js is not returning the correct string:

library.addProfileItem = async (data) => {
	data.links.push({
		id: 'theme',
		route: 'theme',
		icon: 'fa-paint-brush',
		name: 'Theme settings',
		visibility: {
			self: true,
			other: false,
			moderator: false,
			globalMod: false,
			admin: false,
		},
	});

	return data;
};

[sweetp]

here's my plugin.json:

{
    "id": "nodebb-theme-harmony-sweetp",
    "url": "https://github.com/sweetppro/nodebb-theme-sweetp",
    "hooks": [
        { "hook": "static:app.load", "method": "init" },
        { "hook": "filter:admin.header.build", "method": "addAdminNavigation" },
        { "hook": "filter:widgets.getAreas", "method": "defineWidgetAreas" },
        { "hook": "filter:config.get", "method": "getThemeConfig" },
        { "hook": "filter:settings.get", "method": "getAdminSettings" },
        { "hook": "filter:user.saveSettings", "method": "saveUserSettings" },
        { "hook": "filter:user.profileMenu", "method": "addProfileItem" },
        { "hook": "filter:middleware.renderHeader", "method": "filterMiddlewareRenderHeader" },
        { "hook": "filter:middleware.render", "method": "removeFinalBreadcrumb" }
    ],
    "scripts": [
        "../nodebb-theme-harmony/public/harmony.js",
        "scripts/sweetp.js"
    ],
    "modules":
    {
        "../admin/plugins/harmony.js": "../nodebb-theme-harmony/public/admin.js",
        "../client/account/theme.js": "../nodebb-theme-harmony/public/settings.js",
        "sweetp/customHelpers.js": "public/modules/customHelpers.js",
        "sweetp/customHelpers-common.js": "public/modules/customHelpers-common.js"
    },
    "templates": "templates"
}

[baris]

addProfileItem should like this

library.addProfileItem = async (data) => {
	data.links.push({
		id: 'theme',
		route: 'theme',
		icon: 'fa-paint-brush',
		name: '[[themes/harmony:settings.title]]',
		visibility: {
			self: true,
			other: false,
			moderator: false,
			globalMod: false,
			admin: false,
		},
	});

	return data;
};

[sweetp]

@baris ah sorry, that is how the Library.js file looks.
The code I posted is actually from the parent Harmony theme, I guess I posted code from an older commit.

I still have the issue.
Do I need to specifically override library.addProfileItem in my theme to get the correct string?

[sweetp]

I see this error in the console: [Warning] Missing translation "harmony:settings.title" for language "en-GB" (nodebb.min.js, line 9)

[sweetp]

It's not a super big deal, as I hide the button vis CSS anyway. But it would be nice to know how to fix the error

[baris]

Those translation strings are in core now. Maybe you need to update core. https://github.com/NodeBB/NodeBB/blob/master/public/language/en-GB/themes/harmony.json

[sweetp]

Im also getting this error:
[Error] Failed to load resource: the server responded with a status of 404 () (harmony.json, line 0)
for the file:
https://myforum.com/assets/language/en-GB/harmony.json?v=hd29mea4lak

it should be looking in - shouldn't it?
https://myforum.com/assets/language/en-GB/themes/harmony.json?v=hd29mea4lak

[baris]

Yes make sure you don't have any [[harmony:<lang_key>]] in your template files. They should be [[themes/harmony:<lang_key>]]

[sweetp]

that's it.
thanks for your patience