NodeBB v3.0.0-alpha.1 — an alpha release

julian

@phenomlab You have my assurance we won't remove jQuery unless it is part of a major version bump.

The changelog has been updated to specify that custom themes need to have an overrides.scss file in their scss/ folder, even if it contains no actual styles.

Thanks @sweetp for spotting that one.

julian

Added in a note about plugins not being automatically updated by ./nodebb upgrade. Admins will need to manually upgrade them during the alpha/beta/rc phases prior to v3.

phenomlab

@julian @baris where did v3.0.0-alpha.1 go ? I can't see it in git fetch -v ??

julian

@phenomlab It's here.

GitHub release

It's just under a bunch of v2.x releases because we continue to publish patch versions for bug fixes in the v2.x branch.

phenomlab

@julian thanks. What's the best way to install this ? I have an existing dev install I'd like to upgrade but it's not immediately obvious to me as is the normal upgrade path.

julian

@phenomlab Thanks for the feedback! I'll update the original post with some instructions shortly

Alternatively, you could download the .zip or .tar.gz archive and replace your NodeBB directory with those files, though you'd have to take care to preserve the public/uploads folder.

Edit: Done.

phenomlab

@julian I've completed the upgrade to alpha.1 but the persona theme still seems to have the legacy classes, such as pull-right ?

<baris>

We have added some fallbacks for classes like pull-right and pull-left, so thinks don't break completely. We will replace those with float-start/end before release.

phenomlab

@baris Ok, thanks. Not me going mad then

phenomlab

@baris @julian seems 3.0.0-alpha.1 is broken and will no longer build?

Error: Undefined mixin.
    ╷
151 │         @include fa-icon-solid($fa-var-circle-chevron-up);
    │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
  node_modules/nodebb-theme-persona/scss/topic.scss 151:3  @import
  node_modules/nodebb-theme-persona/scss/persona.scss 5:9  @import
  theme.scss 1:9                                           @import
  - 47:9                                                   root stylesheet
    at Object.wrapException (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:1247:17)
    at _EvaluateVisitor1.visitIncludeRule$1 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:81140:17)
    at IncludeRule0.accept$1$1 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:86125:22)
    at IncludeRule0.accept$1 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:86128:19)
    at _EvaluateVisitor_visitStyleRule__closure1.call$0 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:83183:16)
    at _EvaluateVisitor1._evaluate0$_withStyleRule$1$2 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:82072:25)
    at _EvaluateVisitor1._evaluate0$_withStyleRule$2 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:82077:19)
    at _EvaluateVisitor_visitStyleRule_closure20.call$0 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:83175:10)
    at Environment0.scope$1$3$semiGlobal$when (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:80154:25)
    at Environment0.scope$1$2$when (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:80200:19)
2022-10-19T17:06:29.919Z [4571/236519] - error: Error: Undefined mixin.
    ╷
151 │         @include fa-icon-solid($fa-var-circle-chevron-up);
    │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
  node_modules/nodebb-theme-persona/scss/topic.scss 151:3  @import
  node_modules/nodebb-theme-persona/scss/persona.scss 5:9  @import
  theme.scss 1:9                                           @import
  - 47:9                                                   root stylesheet
    at Object.wrapException (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:1247:17)
    at _EvaluateVisitor1.visitIncludeRule$1 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:81140:17)
    at IncludeRule0.accept$1$1 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:86125:22)
    at IncludeRule0.accept$1 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:86128:19)
    at _EvaluateVisitor_visitStyleRule__closure1.call$0 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:83183:16)
    at _EvaluateVisitor1._evaluate0$_withStyleRule$1$2 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:82072:25)
    at _EvaluateVisitor1._evaluate0$_withStyleRule$2 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:82077:19)
    at _EvaluateVisitor_visitStyleRule_closure20.call$0 (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:83175:10)
    at Environment0.scope$1$3$semiGlobal$when (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:80154:25)
    at Environment0.scope$1$2$when (/home/sudonix.dev/nodebb/node_modules/sass/sass.dart.js:80200:19)
sudonix.dev@vps:~/nodebb$ node:events:491
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at target._send (node:internal/child_process:865:20)
    at target.send (node:internal/child_process:738:19)
    at process.<anonymous> (/home/sudonix.dev/nodebb/src/meta/minifier.js:119:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Emitted 'error' event on process instance at:
    at node:internal/child_process:869:39
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
  errno: -32,
  code: 'EPIPE',
  syscall: 'write'
}

And in the log

Hit Ctrl-C to exit


    at renderMethod (/home/sudonix.dev/nodebb/src/middleware/render.js:75:15)
    at async ServerResponse.renderOverride [as render] (/home/sudonix.dev/nodebb/src/middleware/render.js:96:5)
Error: Failed to lookup view "500" in views directory "/home/sudonix.dev/nodebb/build/public/templates"
    at Function.render (/home/sudonix.dev/nodebb/node_modules/express/lib/application.js:597:17)
    at ServerResponse.render (/home/sudonix.dev/nodebb/node_modules/express/lib/response.js:1039:7)
    at /home/sudonix.dev/nodebb/src/middleware/render.js:107:11
    at new Promise (<anonymous>)
    at renderContent (/home/sudonix.dev/nodebb/src/middleware/render.js:106:10)
    at renderMethod (/home/sudonix.dev/nodebb/src/middleware/render.js:75:15)
    at async ServerResponse.renderOverride [as render] (/home/sudonix.dev/nodebb/src/middleware/render.js:96:5)

EDIT: Forgot that this was a replica install of prod, so needed to run ./nodebb upgrade first

phenomlab

Another issue. Despite upgrading plugins from the CLI, I get the below

2022-10-19T17:44:45.677Z [4571/251921] - info: Initializing NodeBB v3.0.0-alpha.1 https://sudonix.dev
2022-10-19T17:44:47.351Z [4571/251921] - warn: [outdated] nodebb-plugin-browsing-users installed v3.0.0, package.json requires ^2.0.4

2022-10-19T17:44:47.353Z [4571/251921] - warn: [outdated] nodebb-plugin-iframely installed v0.7.16, package.json requires ^1.0.0

2022-10-19T17:44:47.354Z [4571/251921] - warn: [outdated] nodebb-plugin-recent-cards installed v3.1.1, package.json requires ^2.0.22

2022-10-19T17:44:47.355Z [4571/251921] - warn: [outdated] nodebb-plugin-question-and-answer installed v0.12.26, package.json requires ^1.0.3

2022-10-19T17:44:47.355Z [4571/251921] - warn: [outdated] nodebb-plugin-poll installed v3.0.0, package.json requires ^2.0.6

2022-10-19T17:44:47.363Z [4571/251921] - error: One or more of NodeBB's dependent packages are out-of-date. Please run the following command to update them:
2022-10-19T17:44:47.363Z [4571/251921] - error:     ./nodebb upgrade

And ./nodebb upgrade does not resolve the issue.

Edit - resolved by removing affected plugins and reinstalling after build.

julian

The outdated warnings are emitted if the current NodeBB version does not satisfy the version reported by the plugin's nbbpm.compatibility, so yes, it's normal prior to v3 to have those warnings emitted.

phenomlab

@julian said in NodeBB v3.0.0-alpha.1 — an alpha release:

so yes, it's normal prior to v3 to have those warnings emitted.

Ok, but this was after the upgrade to alpha?

julian

Technically, according to semver 3.0.0-alpha.1 is below 3.0.0

phenomlab

@baris said in NodeBB v3.0.0-alpha.1 — an alpha release:

We have added some fallbacks for classes like pull-right and pull-left, so thinks don't break completely. We will replace those with float-start/end before release.

Is it possible to get access to a release that has these changes ? Seems pointless remediating existing classes (my theme is all over the place currently) only for them to be removed in the final release.

<baris>

There is no release with pull-left/pull-right removed yet. But you can start updating your theme and use float-start/float-end those are the new names of those classes in bootstrap 5.

phenomlab

@baris thanks. As a test, I completely stripped all of my custom css and the layout is still broken. Not sure why presently.

Can't be my code as it's not there.

julian

Any chance we can take a look? Maybe it's related to column classes

phenomlab

@julian @baris no need. I figured it out. I had to disable nodebb-plugin-customize and also change the theme from and to persona to resolve.

cagatay

As you NodeBB team; could you please share with us when you are planing to relase v3 stable version?