Gotchas for v0.4.0
-
What about these? https://github.com/designcreateplay/NodeBB/issues/1015
-
@mr_waffle Best course of action is to use the passed in
pid
ortid
to get the data by executingmodule.parent.require('./posts').getPostData()
(or.getTopicData
).Just not sure if I should be keeping the current hooks as-is, or creating new ones (i.e.
action:search.index
,action:search.remove
,action:search.reindex
)... -
I think @mr_waffle is looking for the pid and tid to be passed in, which it doesn't currently. Yeah we'll make sure we get that in for 0.4x
-
I forgot to mention this earlier but
$('body').trigger('action:ajaxifying', {url: url});
event hooks are no longer fired on body, but on window instead, like so:
$(window).trigger('action:ajaxify.start', {url: url});
-
The preferred way to start and stop NodeBB is now: ./nodebb start and ./nodebb stop. NodeBB will continue to support usage with forever/supervisor, but it is no longer a requirement for production builds.
Hi @julian
Does it mean if node process crash, it will re-start process automatically?Currently, I was trying to use naught with nodebb, what I want achieve is: Resuscitation - when a worker dies it is restarted & Zero downtime code deployment (optional)
Do I still need to use naught with nodebb 4.x, or I don't need to use naught anymore? -
Defining client-side js files by listening for the filter:scripts.get hook will be deprecated as of v0.5.0, it will continue to be supported until then.
@julian As I mentioned here I'd prefer the filter not beeing deprecated since it can be nice in some cases to decide server-side which scripts to include (e.g. by admin-config). This would need web-socket communication without the filter. You may think about this once more