Plugin Static Directories

frissdiegurke

nice work
will rework some things on my plugins/themes for 0.4.x in a few days when I'll have some spare time ^^
echo 'just spamming your complaint-system' > /dev/null

Theoretically, the key can contain slashes. This is untested. Let me know if it doesn't work

If you haven’t tested it, it doesn’t work

Definitely need to test this ^^

julian

If you haven’t tested it, it doesn’t work

LOL -- you're probably correct in having no faith in me. I'll test it now

julian

See this changeset for tips on migrating.

julian

@frissdiegurke, I think you have to change line 1 of 01.variables.coffee to:

emojiPath = nconf.get('url') + '/plugins/nodebb-plugin-emoji-extended/emoji-extended-images'

But I'm not entirely sure, and can't test because I don't know how to compile coffeescript

frissdiegurke

ya, currently doing so... some other lines too

it seems like there is the bug of 404 if URI encoded path again...

julian

finid

@julian

What's with those over-sized emoticons, is that the new default size. If so, they are taking something away from the real content. They are a distraction.

julian

@frissdiegurke said:

it seems like there is the bug of 404 if URI encoded path again...

Actually, I noticed that as well... so won't be working right away

@planner -- just a temporary setback while @frissdiegurke updates his plugin. I've dropped back to regular emoji for now. Will switch back over when he commits

frissdiegurke

Will switch back over when he commits

done with emoji-extended

julian

Hmm... looks like the CSS (or LESS?) isn't quite making it in...

finid

@frissdiegurke

I have emoji-extended installed on mine, too, but the emoticons are not this size.

frissdiegurke

damn, overlooked the 'css' attribute within plugin.json^^ wait a sec.

julian

... aaand we're back! (minus , for some reason...)

frissdiegurke

@julian said:

... aaand we're back! (minus , for some reason...)

maybe try

var	filePath = path.join(plugins.staticDirs[mappedPath], decodeURIComponent(relPath.slice(mappedPath.length)));

here

julian

Hurrah! Thanks @frissdiegurke