emoji stopped working

sanatisharif

@sanatisharif

What was the solution?

I'm having the same trouble

Actually the solution came by itself . When I checked earlier today I just saw that there is a new update for three of emoji plugins(In Extend Menu ->Plugins). After updating them I found out the problem has been solved .Then I pressed on update files and activate as frissdiegruke had said and finished . emojis are back now.

sanatisharif

@frissdiegurke @pichalite
I was wondering if you could help me with this new problem .
We just upgraded to version 1.0.3 . After upgrading we noticed that during writing a post when you type down the sign : the whole browser tab crashes and you have no choice but closing it.I reinstalled the plugin but didn't help. Then I disabled nodebb-plugin-emoji-apple and the crash issue was gone. I have uninstalled all the emoji plugins and at the time it only has nodebb-plugin-emoji-extended and nodebb-plugin-emoji-apple which is disabled.

frissdiegurke

Is that browser specific? Which one did you test with?

sanatisharif

@frissdiegurke said in emoji stopped working:

Is that browser specific? Which one did you test with?

Google Chrome ( last version )

frissdiegurke

I cannot reproduce. Do you have a live site?

sanatisharif

@frissdiegurke SanatiSharif.ir ( is on production mod and we Disabled emoji-apple on it Because of this bug)

frissdiegurke

There seem to be other javascript errors

js-index.php:2593 Uncaught TypeError: Cannot read property 'value' of undefined
js-index.php:1387 Uncaught TypeError: $(...).flexslider is not a function

I assume when you fix them it'll work since those errors block some javascript of NodeBB itself.

sanatisharif

@frissdiegurke what can I do ?

frissdiegurke

nvm. I assumed you had some custom theme but you just didn't send a direct link to the forum. I don't speak your native language, so next time the direct forum link please.

frissdiegurke

I can reproduce now (on your website), it's not directly related to emoji-extended but one of its dependencies (jquery-textcomplete). I assume it could be because of RTL language; doing further investigations with a local setup now...

EDIT: confirmed on local copy, it's related to the fa_IR language
EDIT2: it's because of data-dir="rtl" on html tag. Update to up-to-date jquery.textcomplete doesn't fix
EDIT3: confirmed jquery.textcomplete bug; v0.7.1 of jquery.textcomplete does work

frissdiegurke

@sanatisharif You can now replace NodeBB/public/vendor/textcomplete/jquery.textcomplete.js with https://raw.githubusercontent.com/frissdiegurke/jquery-textcomplete/master/dist/jquery.textcomplete.js
Then remove NodeBB/public/nodebb.min.js and restart NodeBB.

This should fix the freeze. It however does not fix the dropdown covering the cursor and text beyond. Please report further issues here. When they got solved within upstream, ask the NodeBB devs to update jquery.textcomplete.

Thanks!

sanatisharif

@frissdiegurke
The credit here diffidently goes to you due to your kindness and fantastic support. Thank you so much for you time on this. I am now following the GitHub resource for updates and notices . I hope we can get this fixed as soon as possible.
By the way forgive me for the inconvenience you encountered earlier in accessing to our forum .

sanatisharif

@frissdiegurke

Based on this issue the RTL language bug has been fixed. So now how can we get it fixed on the forum.I mean is there something that we need to update ?

frissdiegurke

@sanatisharif I've sent a PR to NodeBB for updating to latest jquery.textcomplete including the fix. If this is done, it will be fixed within NodeBB and contained within next release.

sanatisharif

@frissdiegurke
That's perfect . Thank you so much for everything.