nodebb-plugin-imgbed doesn't work with v1.0.0

wellenreiter

After upgrading to v1.0.0 the nodebb-plugin-imgbed caused nodebb to shut down.
I needed to disable it in order to get nodebb up and running again after the upgrade

unfortunately I lost the logs, so I can't specify the error message.

Bri

Are you sure? I just tried it and it works. I just need to publish that it's compatible with 1.x.x.

Gaurav Grv Robinson

Does not seem to work for me too. its not generating any previews.

julian

You'll probably have to install the latest version from npm... @bri looks like you need to publish to npm

Gaurav Grv Robinson

@julian Installing manually worked for me. Thanks!

Bri

I found the issue, is this the peer dependency issue you were referring to @julian ? I love how I specify I want this specific version, but npm decides it's ok to use this "upgraded" one instead:

npm WARN unmet dependency /Users/brian/github/NodeBB/node_modules/nodebb-plugin-imgbed requires xregexp@'3.0.x' but will load
npm WARN unmet dependency /Users/brian/github/NodeBB/node_modules/xregexp,
npm WARN unmet dependency which is version 3.1.0

I thought semver was invented to prevent this?

julian

@Bri well, you're using an exact version, and not a range, so npm should've installed the exact version as a dependency under your plugin... but npm decides to do a lot of things its own way.

Bri

I read up on the issue, sometimes it's caused by an older version of npm, sometimes a hiccup in the network, but hopefully newer versions of npm handle dependencies better.

Putting this here for reference for anyone else running into this issue: http://stackoverflow.com/questions/20764881/why-does-npm-install-say-i-have-unmet-dependencies

julian

The npm team tries quite hard to come up with a system to deliver packages efficiently and reliably, so while I have my grievances, I can't deny we'd be lost without them!

My hope is the client code continues to improve as well