Notification grouping now on master branch...
-
Awesome. Thank you
Can you explain how it works? Will it stop from getting the new notification from same topic or is only to show them grouped? -
@julian said:
The notifications are grouped on the way out, so any listeners to existing notifications will still receive all notifications as they occur.
I see. Is it a technical decission?
Will be nice to see this feature extended for native desktop notifications, pushbullet, mail... to precent notification spam
-
I initially wanted to group them as they were created, although it is difficult given that each individual notification can be shared with other users.
It gets complicated in situations like:
- Notification: User replied to topic
- Notification pushed to 4 users
- 2 of those users read that notification
- A different user replied to that topic
Now, what happens here? Do we modify the existing notification object? If we do, then the two users who read the notification already will receive a notification with incorrect data (that is, it will say two users replied to a topic, when it should say 1).
In hindsight, it might actually be better to keep notifications granular, and have each individual client handle duplication separately...
-
@julian said:
I initially wanted to group them as they were created, although it is difficult given that each individual notification can be shared with other users.
It gets complicated in situations like:
- Notification: User replied to topic
- Notification pushed to 4 users
- 2 of those users read that notification
- A different user replied to that topic
Now, what happens here? Do we modify the existing notification object? If we do, then the two users who read the notification already will receive a notification with incorrect data (that is, it will say two users replied to a topic, when it should say 1).
In hindsight, it might actually be better to keep notifications granular, and have each individual client handle duplication separately...
Out of curiousity (I am actually just a user of nodebb, not deverloper or anything), but then.. how is it work if they use the forum?
Example: UserA, UserB, UserC and UserD are following a topic.
- UserX writes a new reply, a notifications is sent to A, B, C and D.
- A and B enter to the forum, A reads the notification and mark it as read. B doesn't mark it as read neither read the new reply.
- A UserY writes a new reply.
What does the forum then? B, C, D should receive a notification as "two new replies" while A should receive a notification as "one new reply".
By the way, perhaps a simple solution is saying: "There are new messages in X topic" and until that the user doesn't mark as "read" the notification, he won't be notificated again.
-
@julian said:
I initially wanted to group them as they were created, although it is difficult given that each individual notification can be shared with other users.
It gets complicated in situations like:
- Notification: User replied to topic
- Notification pushed to 4 users
- 2 of those users read that notification
- A different user replied to that topic
Now, what happens here? Do we modify the existing notification object? If we do, then the two users who read the notification already will receive a notification with incorrect data (that is, it will say two users replied to a topic, when it should say 1).
In hindsight, it might actually be better to keep notifications granular, and have each individual client handle duplication separately...
Do not send notification to the users who didnt read these notifications. In @exodo we modified the notifications and it doesn't send notification to the user who hasn't read last notification about something. For example: if someone favourited your post, you wont receive more notifications about more favs for that post until you read that post.
-
@alberto__segura that works just fine
no need to change what works really.I wanted to have notifications that are always correct. If two users reply, the notification recipient would only get one notif. That's okay, but could be better. These grouped notifications do the trick.
-
@julian said:
@alberto__segura that works just fine
no need to change what works really.I wanted to have notifications that are always correct. If two users reply, the notification recipient would only get one notif. That's okay, but could be better. These grouped notifications do the trick.
yes, grouped notifications are the best solution for the web notifications, but we thought about the plugin and email notifications. If you use the Telegram Bot plugin or the pushbullet plugin, you will receive a lot of notifications from the same topic or post, we doesn't like it, so we tried to fix it. I think both solutions could work together pretty well
-
@alberto__segura offhand, I do not know if those services support changing a notification if it had already gone out.
That'd be best...
-
@julian said:
@alberto__segura offhand, I do not know if those services support changing a notification if it had already gone out.
That'd be best...
I used the telegram plugin and it's true that I was receiving too many notifications.
Perhaps if the forum will send 2 variables it will be easier for the plugin to cull the notifications to avoid sending too many. For example: one variable might say the type of notification (if it's a mention, a message favourited, new answer, etc. ) and another variable might say if there is another mention, message favourited or new answer that haven't been read in that post. (@alberto__segura may that works?)
After all, from what I've seen (as a user) is that little things is what makes people think that nodebb has hundreds of differences with other platforms.
Let the spamming begin.
fat fingers caused me to mention the wrong fellow.