Redactor Composer 1.3.4 Released!
-
@exodo I only really have weekends to look at stuff as I also like to tinker. I know I want to fix a typo in your PR and investigate a mobile view bug and solve that. I didn't want to just shit all over your PR, seemed more productive to merge it to my local, mix minors, push up and release when I have enough time to do it properly. Overall the emoji plugin looks like it's solid in both functionality and structure. It's on tomorrow's list.
I wonder if @julian has any ideas on the mentions plugin compatbility. That's the item that people message and email me about the most.
-
@drew said:
@exodo I only really have weekends to look at stuff as I also like to tinker. I know I want to fix a typo in your PR and investigate a mobile view bug and solve that. I didn't want to just shit all over your PR, seemed more productive to merge it to my local, mix minors, push up and release when I have enough time to do it properly. Overall the emoji plugin looks like it's solid in both functionality and structure. It's on tomorrow's list.
I wonder if @julian has any ideas on the mentions plugin compatbility. That's the item that people message and email me about the most.
No problem, not in a hurry.
Emojis has still work to do to be perfect. Autocomplete and more stuff can be done in future PR, this should just be initial test release -
@drew said:
Note: If you are using the NodeBB Censor Curse Words Plugin it'll break emojis because of its strong desire to remove the word 'ass' from assets.
Auto-suggestion doesn't work yet and I'm not sure what's going on in the admin section (@exodo ?) but that all seems like new future magicthanks for adding it
admin section? dont understand
btw with the changes you made emoji preview is so big
-
@drew said:
@exodo hahahaha, oops. I was looking at Emoji Extended plugin there in the ACP. IGNORE ME.
Emoji Icons are big, but just right on mobile. Perhaps I should look at converting them to BootStrap.
Kinda like 'em big tho.
in mobile i have to swipe down 14 times with that size to reach last emoji on people tab, 19 on symbols tab, , thats no very accesible
i like it big too but faster is better
just my opinion anyways -
Wee suggestion for usability. When I used to start a topic, i'd enter a topic title, pressed Tab to shortcut to the tags field, then tabbed to the text area in the NodeBB composer (which doesn't work in Redactor), then tabbed to the submit button to hit enter to post.
When you start a new topic, you can type into the Redactor section immediately, when it should probably be the post title.
Pressing Tab once highlights the browser tab - so you'd have to hit tab dozens of times to negotiate the links on your page before getting to the topic title.
It's just a little thing, but if you've been used to using Tab as a shortcut to post without using your mouse, then it does become noticeable.
Currently it works like - type post title - tab to category drop down - tab to tags - tab to submit.
Just a wee suggestion
-
For everyone waiting for mentions. It's a 3 step process.
Step 1, NodeBB core needs an update from the @administrators
https://github.com/NodeBB/NodeBB/pull/3688 -
@lulzdevlol At the moment it would involve updating this file:
https://github.com/NodeBB/nodebb-plugin-composer-redactor/blob/master/static/lib/redactor-emoticons.js#L40To have extra items (and then obviously adding those items to the /static/emoji folder.
In the future this can be enhanced to allow emoji upload, and then loading them dynamically, but for now it's a code change.
-
Is it possible to integrate the file manager plugin ?
http://imperavi.com/redactor/plugins/file-manager/
Regards.
-
Couple of issues posted on the Github for you gents.
https://github.com/NodeBB/nodebb-plugin-composer-redactor/issues/30
https://github.com/NodeBB/nodebb-plugin-composer-redactor/issues/29
Is there a button to add emojiis?