Redactor Composer 1.3.4 Released!

[Danny McWilliams]

@drew no problem, I will tonight as soon as I get on my PC

[Danny McWilliams]

@drew issue raised.

[drew]

Tables now added thanks to a pull request from martyalicante

[Danny McWilliams]

The firefox issue has been resolved. Thanks guys!

[Kalbaskin]

Awesome redactor!

Firefox bugs:

• Answer button works only once a topic.
• Editing also works one time, the second editing is not saved.

Helps only reload the page. And then everything is repeated until the next F5.

[Ali]

Encountered bugs:

• Redactor buttons doesn't even appear using Paper skin
• this button does nothing
• can't change it's language.

[drew]

@Ali language is hard coded for now. Sorry.

[Ali]

I can just change code inside but I need to change charset too. Where is it?

[drew]

@Ali I don't think it's defined anywhere:
https://github.com/NodeBB/nodebb-plugin-composer-redactor/search?utf8=✓&q=charset

[exodo]

been working on emoji support
hope you like it

@drew
https://i.imgur.com/GBtuMvj.png

[Danny McWilliams]

@exodo said:

been working on emoji support
hope you like it

@drew
https://i.imgur.com/GBtuMvj.png

Would love this. Splitting the emoji up into categories is also a great idea.

[exodo]

@Danny-McWilliams said:

@exodo said:

been working on emoji support
hope you like it

@drew
https://i.imgur.com/GBtuMvj.png

Would love this. Splitting the emoji up into categories is also a great idea.

Already pulled a few days ago. Hope drew will have time soon to check it out

[lulzdev]

Just wanted to stop in here and say that this WYSIWYG composer is really very good.

[drew]

@exodo I only really have weekends to look at stuff as I also like to tinker. I know I want to fix a typo in your PR and investigate a mobile view bug and solve that. I didn't want to just shit all over your PR, seemed more productive to merge it to my local, mix minors, push up and release when I have enough time to do it properly. Overall the emoji plugin looks like it's solid in both functionality and structure. It's on tomorrow's list.

I wonder if @julian has any ideas on the mentions plugin compatbility. That's the item that people message and email me about the most.

[exodo]

@drew said:

@exodo I only really have weekends to look at stuff as I also like to tinker. I know I want to fix a typo in your PR and investigate a mobile view bug and solve that. I didn't want to just shit all over your PR, seemed more productive to merge it to my local, mix minors, push up and release when I have enough time to do it properly. Overall the emoji plugin looks like it's solid in both functionality and structure. It's on tomorrow's list.

I wonder if @julian has any ideas on the mentions plugin compatbility. That's the item that people message and email me about the most.

No problem, not in a hurry.
Emojis has still work to do to be perfect. Autocomplete and more stuff can be done in future PR, this should just be initial test release

[drew]

EMOJIS ARE HERE PEOPLE

[drew]

Note: If you are using the NodeBB Censor Curse Words Plugin it'll break emojis because of its strong desire to remove the word 'ass' from assets.

[exodo]

@drew said:

Note: If you are using the NodeBB Censor Curse Words Plugin it'll break emojis because of its strong desire to remove the word 'ass' from assets.
Auto-suggestion doesn't work yet and I'm not sure what's going on in the admin section (@exodo ?) but that all seems like new future magic

thanks for adding it
admin section? dont understand
btw with the changes you made emoji preview is so big

[drew]

@exodo hahahaha, oops. I was looking at Emoji Extended plugin there in the ACP. IGNORE ME.

Emoji Icons are big, but just right on mobile. Perhaps I should look at converting them to BootStrap.

Kinda like 'em big tho.

[exodo]

@drew said:

@exodo hahahaha, oops. I was looking at Emoji Extended plugin there in the ACP. IGNORE ME.

Emoji Icons are big, but just right on mobile. Perhaps I should look at converting them to BootStrap.

Kinda like 'em big tho.

in mobile i have to swipe down 14 times with that size to reach last emoji on people tab, 19 on symbols tab, , thats no very accesible
i like it big too but faster is better
just my opinion anyways