Redactor Composer 1.3.4 Released!

[drew]

@Danny-McWilliams To clarify, they wouldn't be added "back in". This is a new plugin so they'd just be added.
Creating a button and functions isn't too complicated. @exo-do just sent a pull request for adding tables in today. Take a look at the Redactor documentation, and feel free to give it a shot.

[drew]

@Danny-McWilliams said:

Highlighting text doesn't work 9/10 in WYSIWYG mode
To highlight text, having to switch to HTML mode.
when text is highlighted and the link button clicked, the text you've highlighted isn't passed to the "text" box under where you enter the URL. It has to be re-entered.

Gonna have to give that a test to recreate and debug. Could you please raise an issue for it on GitHub?

[Danny McWilliams]

@drew no problem, I will tonight as soon as I get on my PC

[Danny McWilliams]

@drew issue raised.

[drew]

Tables now added thanks to a pull request from martyalicante

[Danny McWilliams]

The firefox issue has been resolved. Thanks guys!

[Kalbaskin]

Awesome redactor!

Firefox bugs:

• Answer button works only once a topic.
• Editing also works one time, the second editing is not saved.

Helps only reload the page. And then everything is repeated until the next F5.

[Ali]

Encountered bugs:

• Redactor buttons doesn't even appear using Paper skin
• this button does nothing
• can't change it's language.

[drew]

@Ali language is hard coded for now. Sorry.

[Ali]

I can just change code inside but I need to change charset too. Where is it?

[drew]

@Ali I don't think it's defined anywhere:
https://github.com/NodeBB/nodebb-plugin-composer-redactor/search?utf8=✓&q=charset

[exodo]

been working on emoji support
hope you like it

@drew
https://i.imgur.com/GBtuMvj.png

[Danny McWilliams]

@exodo said:

been working on emoji support
hope you like it

@drew
https://i.imgur.com/GBtuMvj.png

Would love this. Splitting the emoji up into categories is also a great idea.

[exodo]

@Danny-McWilliams said:

@exodo said:

been working on emoji support
hope you like it

@drew
https://i.imgur.com/GBtuMvj.png

Would love this. Splitting the emoji up into categories is also a great idea.

Already pulled a few days ago. Hope drew will have time soon to check it out

[lulzdev]

Just wanted to stop in here and say that this WYSIWYG composer is really very good.

[drew]

@exodo I only really have weekends to look at stuff as I also like to tinker. I know I want to fix a typo in your PR and investigate a mobile view bug and solve that. I didn't want to just shit all over your PR, seemed more productive to merge it to my local, mix minors, push up and release when I have enough time to do it properly. Overall the emoji plugin looks like it's solid in both functionality and structure. It's on tomorrow's list.

I wonder if @julian has any ideas on the mentions plugin compatbility. That's the item that people message and email me about the most.

[exodo]

@drew said:

@exodo I only really have weekends to look at stuff as I also like to tinker. I know I want to fix a typo in your PR and investigate a mobile view bug and solve that. I didn't want to just shit all over your PR, seemed more productive to merge it to my local, mix minors, push up and release when I have enough time to do it properly. Overall the emoji plugin looks like it's solid in both functionality and structure. It's on tomorrow's list.

I wonder if @julian has any ideas on the mentions plugin compatbility. That's the item that people message and email me about the most.

No problem, not in a hurry.
Emojis has still work to do to be perfect. Autocomplete and more stuff can be done in future PR, this should just be initial test release

[drew]

EMOJIS ARE HERE PEOPLE

[drew]

Note: If you are using the NodeBB Censor Curse Words Plugin it'll break emojis because of its strong desire to remove the word 'ass' from assets.

[exodo]

@drew said:

Note: If you are using the NodeBB Censor Curse Words Plugin it'll break emojis because of its strong desire to remove the word 'ass' from assets.
Auto-suggestion doesn't work yet and I'm not sure what's going on in the admin section (@exodo ?) but that all seems like new future magic

thanks for adding it
admin section? dont understand
btw with the changes you made emoji preview is so big