Official: Redactor Composer now available in 0.7.1+

exodo

Disable HTML Sanitisation / Enable HTML usage

Sorry for the confusing text

i see

drew

@yariplus I don't get that message on FF.
I get:
downloadable font: OS/2: bad linegap: -32 (font-family: "RedactorFont" style:normal weight:normal stretch:normal src index:0) source: data:application/x-font-ttf;charset=utf-8;base64{someBase64} stylesheet.css:13:31133 but that's it.

yariplus

@Drew-Llewellyn

Hmm, I tried disabling my plugins, but it's still happening.

FireBug tells me it's from this code in public/src/overrides.js:

		//http://stackoverflow.com/questions/511088/use-javascript-to-place-cursor-at-end-of-text-in-text-input-element
		$.fn.putCursorAtEnd = function() {
			return this.each(function() {
				$(this).focus();

				if (this.setSelectionRange) {
					var len = $(this).val().length * 2;
					this.setSelectionRange(len, len);          // Throws error here
				} else {
					$(this).val($(this).val());
				}
				this.scrollTop = 999999;
			});
		};

The error could be unrelated, but the cursor is the main problem. I can type, but I can't move the cursor or select things. And buttons seem to work only when they feel like it. Submit does post though.

chrismccoy

impressive a $500 donation

psychobunny

Yeah @Codejet I get your feelings, and probably markdown is the better solution today (which is why the redactor composer is not default right now)

Hopefully we get to a point where we get an awesome WYSIWYG composer that blows other forum composers out of the water. One step at a time

Whatever the community can contribute will make this thing more awesome, exactly like how we have progressed with the core itself so far.

drew

Well said @psychobunny

drew

For anyone looking to contribute, the repo is here:
https://github.com/NodeBB/nodebb-plugin-composer-redactor.
Fork, improve, make a pull request.

drew

@julian
I can't DM you because you don't follow me. Just updated Redactor in the github repo. I don't think I have permission to publish the npm package though.

phil

The new composer looks nice. Very impressive work.

Just one quick question. Are you doing server side HTML sanitization or are you completely relying on Redactor to provide clean HTML? If so, where is the server side code that does the sanitization.

phil

@phil said:

The new composer looks nice. Very impressive work.

Just one quick question. Are you doing server side HTML sanitization or are you completely relying on Redactor to provide clean HTML? If so, where is the server side code that does the sanitization.

OK, I've answered my own question. No server side sanitization. It's very easy to inject javascript code into a post for XSS.

I would strongly recommend not deploying this to a production site until server side html sanitization is implemented. If any of the devs would like to know how I XSS'd my test site, let me know.

phil

@phil said:

@phil said:

The new composer looks nice. Very impressive work.

Just one quick question. Are you doing server side HTML sanitization or are you completely relying on Redactor to provide clean HTML? If so, where is the server side code that does the sanitization.

OK, I've answered my own question. No server side sanitization. It's very easy to inject javascript code into a post for XSS.

I would strongly recommend not deploying this to a production site until server side html sanitization is implemented. If any of the devs would like to know how I XSS'd my test site, let me know.

I've forked and am adding server side validation. Does redactor have a list of all the tags and attributes that pass it's validation? In order for server side validation to not mess things up, it needs to perform the same validation the client performs. It would be even more useful if the guys over at redactor made their client side validation code available in a separate library.

drew

@phil they have a list of tags they *don't * take:
http://imperavi.com/redactor/docs/security/

But no explicit list of ones they do. I can see from your pull request you've added a list. Is that one you took from somewhere specific or built yourself?

A huge thank you to you @phil for making a contribution to the Redactor composer plugin. Gold stars and dancing girls for you!*

(* gold stars not made of real gold. Dancing girls may or may not be dancing, may or may not be girls. Offer void in Utah)

phil

@drew said:

@phil they have a list of tags they *don't * take:
http://imperavi.com/redactor/docs/security/

But no explicit list of ones they do. I can see from your pull request you've added a list. Is that one you took from somewhere specific or built yourself?

I dug through the Redactor source to find what they were sanitizing against and made the list to match what they were doing.

A huge thank you to you @phil for making a contribution to the Redactor composer plugin. Gold stars and dancing girls for you!*

(* gold stars not made of real gold. Dancing girls may or may not be dancing, may or may not be girls. Offer void in Utah)

tfraley

I've run into an issue (I've posted on github with no response) figured I would try here.

When activating redactor it seems I cannot compose a post in Safari, however, it works fine in chrome. Any thoughts on this. Others in github were able to reproduce the issue so its' not a theme issue.

Safari broken · Issue #4 · NodeBB-Community/nodebb-plugin-composer-redactor

Cant write text on safari browser, mac & iOS

GitHub (github.com)

drew

@tfraley You're getting replies on github, but I think what you're saying is it's not fixed. If you know js, and you have safari (or anyone reading this) pull requests welcome!

chrismccoy

anyone else having an issue when uploading file(s) they dont show up in the compose window, only the preview window

drew

@chrismccoy I think you're talking about the default markdown composer, this thread is for the redactor composer, which is a wysiwyg and has no composer/preview split.

chrismccoy

i have the default disabled, but markdown enabled, im guessing i have to disable the markdown plugin?

alberto__segura

Safari bug fixed on my pull request https://github.com/NodeBB/nodebb-plugin-composer-redactor/pull/12

drew

@chrismccoy file upload not yet working in Redactor Composer. We've got a bug report on the Github and hopefully a pull request incoming.