[nodebb-plugin-poll] Poll plugin

[A Former User]

If @Schamper got this working, I'd give him an internets. But then v0.50 would probably break it again, so I'd just have to take it back temporarily.

[Scuzz]

We have it working over at BitBangers and we are on stable release.

[ffmad]

it does not work on my website too http://www.cryptofr.com/topic/9/test-sondage/3

if you can fix it, it would be really kind ^^

[A Former User]

@Scuzz, any code modifications required?

[Scuzz]

@Ted I have not made any changes to the code.
I'm not sure if i have the npm version or the github version.

we are on 0.4.3 of NodeBB.

[A Former User]

@Scuzz thanks for the speedy response. Hopefully I'll get a chance to test this out in the coming days, though I may just wait until Schamper gets a chance to update it after the v.50 release.

[Scuzz]

@Ted This is how it looks in use

[ffmad]

@Schamper Could you reworked it a little to make it work again ?

[trevor]

Those numbers though.

[Schamper]

@trevor ssshhh... that's a known issue

I'll have a lot more time after the weekend. I'll take a look at this again.

[trevor]

@Schamper said:

@trevor ssshhh... that's a known issue

I'll have a lot more time after the weekend. I'll take a look at this again.

My bad, I'm sure you already knew though. Maybe that was a friendly reminder

[Scuzz]

@trevor We like to be super accurate

[dylenbrivera]

Is this still in the works?

[Netto Hikari]

Any news on the number problem, @Schamper ? Shouldn't be that hard to round or just cut off the trailing unneeded digits, right?

Great plugin, though.

[a_5mith]

total = Math.round(total); would do it. (I think)

[Scuzz]

@Netto-Hikari @a_5mith Submit a pull request

[a_5mith]

From an iPad? Are you mad? I'll take a look when I get on my laptop.

[a_5mith]

Submitted the PR. It will now show results to 1 decimal place, not 80.

var percentage = ((poll.options[option].votecount / poll.info.votecount) * 100).toFixed(1);

[A Former User]

@a_5mith You could have done that with an iPad

[a_5mith]

@Ted Browsing code on github from an iPad is painful. The actual code itself was simple enough, but finding it, not so much. I also had to test it worked on my development server first, can't go blindly submitting pull requests.

Plus, knowing my iPad, it would have auto corrected toFixed to something like tomorrow.

EDIT: PR has been merged, he's currently on holiday. (Probably Github camp by the speed he accepted the PR )