Community

How to set a mobile icon for when you add a NodeBB website to your home screen. (e.g. iOS add to homescreen feature)

NodeBB Development

Suggested Topics

  • aditya-appyhighA

    Image upload plugin in nodebb 2.x

    NodeBB Development
    0 Votes
    4 Posts
    199 Views
    oplik0O

    More specifically, the issue is that it defines a static directory in plugin.json:

    "staticDirs": { "s3": "public" },

    But doesn't have it.

    It seems to be an artifact of people forking and updating it without fully understanding what exactly it was doing - looking back at some history at some point someone moved the templates from public/templates to just templates/ and apparently NodeBB wasn't enforcing that directories have to exist at that point, so it wasn't noticed and all future forks inherited this bug.

    NodeBB is IMO doing fine here - a lack of directory a plugin declared to have might suggest some issue with the installation or the plugin itself (for example a typo in a path). A plugin incorrectly declaring something it doesn't use can't really be distinguished from these issues.

    Also, @julian while .gitignore works, I feel like it's a bit of abuse of that feature and the name is misleading (upon seeing a directory with .gitignore my first thought would be that something is supposed to go there but will be ignored. And I feel without knowing much about git I might've assumed it meant the whole directory would be ignored by git - the opposite of what it actually does). I personally prefer the convention of using an empty file named .gitkeep (or just .keep), since it more obviously refers to keeping the directory and wouldn't have any other potential impact on files included by git.

    EDIT: TL;DR of the issue:
    why would nodebb do this

  • AntosikA

    NodeBB Core typings

    NodeBB Development
    0 Votes
    2 Posts
    186 Views
    PitaJP

    I don't think this is realistic until core switches to typescript.

  • A

    How do I set up my dev environment for child themes?

    Moved NodeBB Development
    0 Votes
    3 Posts
    1220 Views
    PitaJP

    You don't need to run ./nodebb upgrade every time you make changes. You just need to run ./nodebb build. You can use the --dev flag to make it faster because you don't need minification during dev.

    You can also use grunt to dev but you'll need to disable the emoji plugin.

  • GiggiuxG

    NodeBB ES6/7

    NodeBB Development
    0 Votes
    11 Posts
    3267 Views
    julianJ

    Thanks @yariplus ... with that statement, at least two plugin developers I know are now writing code that cannot be used in Node 4, which is the oldest LTS we officially support.

    It certainly lends credence towards the eventual dropping of Node v4 support.

  • SchamperS

    Perfect way for requiring NodeBB modules?

    NodeBB Development
    1 Votes
    4 Posts
    2226 Views
    SchamperS

    To get back on this, I have currently solved it in the following way:
    ###/lib/nodebb.js:

    module.exports = { "Meta": module.parent.parent.require('./meta'), "User": module.parent.parent.require('./user'), "Plugins": module.parent.parent.require('./plugins'), "SocketIndex": module.parent.parent.require('./socket.io/index'), "ModulesSockets": module.parent.parent.require('./socket.io/modules'), "db": module.parent.parent.require('./database') }

    ###library.js:

    var NodeBB = require('./lib/nodebb');

    ###/lib/submoduleX.js:

    var NodeBB = module.require('./nodebb'), db = NodeBB.db, User = NodeBB.User, Plugins = NodeBB.Plugins;

    ##Why this works
    I read somewhere that require caches the files you load. That means that if require my nodebb.js from library.js, I can later load nodebb.js from any submodule I want and it will work.

Copyright © 2023 NodeBB | Contributors