Composer Button Tooltips

[NedFodder]

I see we now have tooltips on (most of) the composer buttons thanks to this:

composer toolbar images missing "title" attributes · Issue #32 · NodeBB/nodebb-plugin-composer-default

It would be it more user friendly to be able to hover over a toolbar image and get a tooltip as to the functionality. Cheers.

GitHub (github.com)

I wrote a plugin that uses composer.addButton() to add buttons to the composer. I'd like to add tooltips to my buttons, but composer.addButton() (and formatting.addButton() for that matter) doesn't give me a way to pass a title down.

I can do it the way the markdown plugin does it (add the title by hooking on to filter:composer.formatting and then calling formatting.addButtonDispatch()), but that's a lot more work than just calling composer.addButton() on the client side.

What do the powers-that-be (I'm guessing @baris mostly) think about adding a way to pass the title to composer.addButton()?

[baris]

Yes that makes sense, I will make that change.

[NedFodder]

@baris Just tried out 3.0.27, works great, thanks! There's still one difference: with filter:composer.formatting the text is run through the translator automagically, but with composer.addButton() I have to translate it first. Not a big deal, just pointing that out...