Fixed with v2.3.1 🙂
Hm, it's now showing 0.9.4 after I cloned another nodebb with:
git clone -b v0.9.3 https://github.com/NodeBB/NodeBB.git nodebb
Then moved .git from that installation to my forum nodebb.
Then I ran:
git checkout -f v0.9.x
git merge origin/v0.9.x
And ran ./nodebb upgrade
And ran npm install + npm update a few times.
I have no idea what all of this is supposed to do but since ACP is now showing 0.9.4 I suppose it's all right, right?
Please update the upgrade instructions - It doesn't seem like those git commands really do anything meaningful ... and there is no mention of npm update which eventually seemed to fix the issues I was having with Nodebb not updating...
If correctly installed, the
.git directory would be there. Maybe you've copied "everything" within the NodeBB directory at one time and since directories starting with
. are hidden by default, you've lost this during it.
And if the
.git directory is there, the update commands within the docs make sense.
npm update (more specific
npm install --production, which does include package update) gets called during the
./nodebb upgrade command.