Are there any #Nodejs experts in TLS/SSL who can review this pull request and comment as to if the implementation is correct?

Emelia 👸🏻

fix(pg-connection-string): get closer to libpq semantics for `sslmode` by pmalouin · Pull Request #2709 · brianc/node-postgres

Summary We have found that the handling of the sslmode connection string parameter is inconsistent with other PG libraries and with the reference libpq documentation. This PR proposes some changes ...

GitHub (github.com)

This would be of a fantastic help to the Mastodon project.

cc maybe @indutny, @Trott or anyone?

Rich Trott

@thisismissem @indutny I'll ping a few people in that PR.

Emelia 👸🏻

@Trott @indutny thanks! We've been blocked on this for ages, and I just don't know the right things to do to move forwards here: https://github.com/mastodon/mastodon/pull/31667

Rich Trott

@thisismissem @indutny I don't know that I have anything helpful to suggest, but if there's a way I can assist, I'm happy to try.

Emelia 👸🏻

@Trott @indutny thanks, what you've done has been super helpful and appreciated. We've been stuck on this for months.

Fedor Indutny

@thisismissem @Trott sorry, it isn't entirely clear what kind of review I can provide on this. It seems to be more about compatibility with some other project than a pure TLS/SSL usage in Node.js

Emelia 👸🏻

@indutny well, libpq supports SSL modes that aren't immediately obvious how to support in node.js