Beginning to believe that @Gargron doesn't want me contributing to #mastodon — he's now partially recreated three of my pull requests that I've worked on.
-
Emelia 👸🏻replied to Emelia 👸🏻 last edited by [email protected]
His PR: https://github.com/mastodon/mastodon/pull/32816
My PRs:
- https://github.com/mastodon/mastodon/pull/31557
- https://github.com/mastodon/mastodon/pull/31449His PR: https://github.com/mastodon/mastodon/pull/32836
My PR: https://discord.com/channels/@me/1273800704523505674/1305613796756291658
Like seriously, I spend a lot of time trying to get the moderation features right, and thinking through all the feedback I've read when I've reviewed all the open moderation issues on the project.
He's also done this to me in the past in 2018 with the report management tools.
-
@stinerman It's twice, or even thrice now that @Gargron has duplicated or partially duplicated my work instead of reviewing it.
-
@thisismissem @Gargron oversight is probably the wrong word. I just hope it is unintentional and steps are taken to correct this in the future.
-
All of the PRs that @Gargron has redone of mine only partially improve things.
Report forwarding? Yeah, you want to track which domains you've actually forwarded to, especially on reports that could be forwarded to multiple other domains. You also want to be able to override the report comment incase there's user sensitive data in the comment that shouldn't be forwarded.
I spent a long time thinking this through and trying to get the UI right.
-
@thisismissem @Gargron There is a long history of features not arriving to Mastodon because grandmaster doesn't feel like it :blobcatshrug:
I would be furious if I was a contributor, so I guess I'm happy I am not :blobcatlook:
-
The Reports list and details pages? Once again @Gargron's quick PRs don't actually address the issues where the layout was confusing, didn't show enough information or displayed it in confusing ways.
The new theme in 4.3 also completely broke the visual hierarchy of the Report details page, which I've done a bunch of work on redesigning to make clearer https://github.com/mastodon/mastodon/issues/31444 (I haven't opened a branch yet because I wanted to have the UX right first)
-
@gytisrepecka @thisismissem @Gargron
Well this is how BDFL works. I don't really have a problem with that. Someone has to make the decision. In this case it's Eugen.If people don't like the decisions they're welcome to complain and ask others to complain as well, but at the end of the day their only recourse is to click the fork button.
-
Here's the same thing happening in 2018 when I was contributing to the moderation tools:
My PR: https://github.com/mastodon/mastodon/pull/7062
His PR: https://github.com/mastodon/mastodon/pull/7188
My PRs all try to address a single area / issue, as that's what the team has asked for whenever I've submitted larger PRs touching on multiple issues.
-
Bloody Gothic Rose 666replied to Emelia 👸🏻 last edited by
@thisismissem yeah he did the same thing to me with the search features
-
@thisismissem
I wish I could say this is surprising, but my understanding is that it's actually pretty common behavior for him. -
Emelia 👸🏻replied to Emelia 👸🏻 last edited by [email protected]
I'm no longer just some "new developer" working on the project, instead I've 92 merged pull requests, and 37 open, waiting for review.
I'm fairly certain that @Gargron only even thought of report forwarding because after his first PR that conflicted with my ongoing work, I mentioned that I'd been working on report forwarding in a conversation.
-
@jenniferplusplus like, usually I'm able to get things to ship, but everything got backlogged due to the release, and I'm waiting for the team to green light continuing on work, because rebasing constantly is a waste of time.
-
this is really pissing me off, because like, I could've been spending that time working on other things, like FIRES, but instead I pushed hard on Mastodon moderation features to *try* to move things forwards for 4.3
Features that @Gargron had left underloved for months or years, not responding to moderator feedback.
-
Michał "rysiek" Woźniak · 🇺🇦replied to Nathan A. Stine last edited by
@stinerman I have a serious problem with the very idea of a BDFL in the context of a project that important for so many underserved, at-risk communities as Mastodon-the-software.
-
Lars Marowsky-Brée 😷replied to Michał "rysiek" Woźniak · 🇺🇦 last edited by
@rysiek @stinerman @gytisrepecka @thisismissem To be more correct: this is how BDFL projects *stop* working.
-
@thisismissem @Gargron you know, I saw this on a totally unrelated repo — someone submitted a feature PR, and instead of building on that PR the maintainer put up a duplicate with slightly different implementation and then deleted the original. It seemed like a rude one-off to me at the time but maybe this is a larger trend.
-
Daveyreplied to Michał "rysiek" Woźniak · 🇺🇦 last edited by
BDFL is often fine for very mechanical things like a programming language. Even then it requires being an accomplished domain expert. Someone with so much trust that it's not like anyone is going to disagree much anyway.
Fedi software has a cyclic dependency of voluntary labour by people who trust a dev to do work that supports them. I can''t think of any free software that has that dynamic to this extent.
To survive, it needs to be more dialogue, less monologue.
-
@rysiek @stinerman as an admin/mod, Mastodon is fine, on balance, but I really see some of the decision making as a limiting factor on:
- adoption by new communities
- sense of safety
- feelings of independence from corporate interference
- how long some volunteers will hang on or burn out or switch techLike all the getting excited about integrating with Facebook. Can't help asking "why does this lad think people are here?"
-
@thisismissem @Gargron 37 open prs? ugh that sucks unless there are actually good reasons for that...
-
@logicalmoody I'd certainly seen it before, but usually the original author's implementation was "better" for justifiable reasons — with at least the latest here, he knew as of this morning that I was working on that feature, because I'd told him, but he still decided to open a quarter-implementation of that feature anyway for some reason.
