I just lost a category full of threads when making a new category

[baris]

If a category has itself as the parent that would cause an infinite loop in the category retrieval. We should disallow that. Can you post a link to your forum?

[baris]

If you are on latest update to https://github.com/NodeBB/NodeBB/commit/5b08538264846717b350df8c5ce1d44a0cd56c50

0 barisusakli committed to NodeBB/NodeBB

closes #3614

[Pilvinen]

Confirmed the problem is fixed by this in latest master. I can now access the category which previously caused infinite loop. By the way, in the Redis database the broken category didn't have itself as parent so I don't know why this would happen ... but it works now so I'm happy. Thanks.

[baris]

@Pilvinen there is another sorted set that has the categories children. Check that as well.

zrange cid:<parent_cid>:children 0 -1

replace <parent_cid> with the category id of the parent.

[Pilvinen]

@baris
You were right. The zrange of that category still has itself set as the parant. I'm a bit hazy on the details how the zranges work ... how do I change that value?

[baris]

Post the output of the zrange that you run.

[Pilvinen]

@baris

zrange cid:7:children 0 -1
1 ) "7"

[baris]

You can remove it by zrem cid:7:children 7

[Pilvinen]

@baris
Thanks. It's now been removed - though the forums already worked fine even without this after the infinite loop was prevented. But better safe than sorry.

[baris]

Yeah it does work because of the check I added in core. I also added a check so you can't set the parent to itself to prevent it happening again.