Community

cache-buster change

NodeBB Development

Suggested Topics

  • barisB

    1.10.0 Breaking Changes

    NodeBB Development
    1 Votes
    3 Posts
    2377 Views
    attisA

    Hi,
    I think I have discovered another breaking change that you didn't mention, though it is probably super-niche.

    This commit: https://github.com/NodeBB/NodeBB/commit/ec91ef1c644044bba44198b031913655e784b4bb
    broke our custom SSO plugin. The result was that after successfully logging in our external identity provider and being redirected to our Forum's callback endpoint, I was ending up not logged in (the button in the header still said "Log in") and stuck on /register/complete roadblock. It looked like our Passport strategy verify callback, that parses output from the identity provider and fetches user data via OAuth2 was not invoked at all.

    It turns out that the changes in this commit don't play well together with passport-oauth2 (https://github.com/jaredhanson/passport-oauth2) internal ability to protect against CSRF (which we were using). This strategy was already using state parameter to pass its own CSRF token. I don't have more time to investigate but I suspect things shipwrecked when NodeBB overwrote the state parameter with its own CSRF token.

    Turning off passport-oauth2 internal CSRF protection (by removing state: true from its options) fixed the issue.

  • A

    How to change scroll target for notifications, etc?

    NodeBB Development
    0 Votes
    2 Posts
    765 Views
    A

    If anyone is curious, I found a workaround using jQuery!

    It's kind of cheaty because it's using time, but basically I set an interval to run every 100ms a total of 100 times. Each time it checks where my posts are (.awge-windows-container) and looks for a highlight class. If it finds it, it will scroll down and cancel the interval. It's cheaty, but it works without disturbing anything 🙂

    Code below

    var foundHighlight = false; function setIntervalX(callback, delay, repetitions) { var x = 0; var intervalID = window.setInterval(function() { callback(); if (++x === repetitions || foundHighlight) { window.clearInterval(intervalID); } }, delay); } setIntervalX(function() { $('.awge-windows-container').each(function(ind, obj) { if ($(obj).find(".highlight").length > 0) { $(obj).animate({ scrollTop: $($(obj).find(".highlight")[0]).offset().top }, 2000); foundHighlight = true; } }); }, 100, 100);
  • barisB

    timestamp change

    NodeBB Development
    0 Votes
    3 Posts
    1959 Views
    NicolasN

    But... It's a breaking change.
    You should not do such stuff when you have now 1.0

  • K

    Change email digest appearance

    NodeBB Development
    0 Votes
    5 Posts
    1711 Views
    pichaliteP

    @KasparTr template files in /public/templates gets recompiled from source files everytime you restart/reload nodebb.

  • barisB

    1.0.0 Breaking Changes

    NodeBB Development
    3 Votes
    10 Posts
    7468 Views
    S

    0_1457071644710_nbb1.0.0.PNG

    No announcement thread in the announcements section?

    Congratulations, guys! NodeBB has come a long way.

Copyright © 2023 NodeBB | Contributors