Official: Redactor Composer now available in 0.7.1+

[drew]

@alberto__segura Thank you very much for the pull request. It's been merged and new npm package released.

[tfraley]

Let me start by saying its working well in safari.

Ok I may have missed something here. How come I do not have an upload / Image / video options

like shown in the first image. Am I missing an option or another plugin that is needed?

all I have is

[drew]

There's a enhancement request on the github for this.

[tfraley]

@drew

Thanks, I just found that a little while ago.

But will say that the image at the top of this thread is misleading, it should relate to how the plugin actually looks since you are advertizing the plugin.

Just my 2cents for what it's worth..

[Pilvinen]

For free? That's cool.

I just installed it and seems to be working. A bit strange that there is no separate icon for adding images. I know you can drag and drop, but it might not be so intuitive for everyone.

[drew]

@Pilvinen Something we'll be working on. So far the support from plugin developers has been good (thank you to contributors so much) and I hope a lot more devs help make this a great addition to the NodeBB package.

[julian]

@drew you're getting contributors faster than NodeBB itself is!

[drew]

@julian I'm just glad the demand for this is as real as I expected. I think it'll really help your offering for hosted packages and B2B sales too.

[Pilvinen]

Just an informal heads up:

There is possibly some page load blocking bug related to perhaps deleting posts or adding images in the redactor (I'm not sure).

I just noticed in one of the test threads that I made for the new Redactor composer that it doesn't load the thread unless you do a page refresh (broken html?). But that thread has already been deleted before I realized that I should study it more closely and make a bug report, so ...

But I'll keep an eye out to see if it happens again.

[drew]

@Pilvinen Thanks, if it happens again and you can specify how to recreate please add it to the github issues.

[drew]

Thanks to @yariplus enhanced sanitization is now included and 1.0.8 is released.

[drew]

1.0.9 drops the redactor styles imposed on the composition block to instead give inheritance to .topics, .posts, .content so it is styled the same as the actual comment will be.

[drew]

The reply button needs a change to nodebb core to work (call out to composer to handle it). I've raised a github issue for it.

[drew]

1.0.10 allows for dynamic insertion of buttons as per
https://github.com/NodeBB/nodebb-plugin-composer-redactor/pull/16
and
https://github.com/NodeBB/nodebb-plugin-composer-redactor/issues/10

One issue awaits the NodeBB team to update core to better reflect a "more than one type of composer" environment" ( @julian pretty please)
https://github.com/NodeBB/nodebb-plugin-composer-redactor/issues/15

[drew]

oh and a big shout out to @yariplus for his continued support of this project's code. Much love

[Pilvinen]

Hm. After installing Redactor I'm not seeing these -> in a popup helper anymore.

They still work in the posts but it's rather difficult to find them without the popup helper thing.

Is this a problem in my installation or bug/lack of feature in Redactor?

[drew]

@Pilvinen I'd say it's time to raise a feature request on the issues list.
If you're capable of coding, please feel free to contribute!

[drew]

1.0.12 released. Image uploads now work. Hooray!

[drew]

Is anyone able to put in the default quote thing now?
https://github.com/NodeBB/nodebb-plugin-composer-redactor/issues/15
The changes have been made to core, but I'm out to sea with what needs to happen in the redactor plugin for this.
Here's the key changes and areas of interest from what I can gather::
https://github.com/NodeBB/NodeBB/commit/cf36f7bc79258f5e2ae933d6ee7a059adc2e377d
https://github.com/NodeBB/nodebb-plugin-composer-default/commit/1d37b6d1556656019e1cbbf3956b4efe5d0046e0
https://github.com/NodeBB/nodebb-plugin-composer-redactor/blob/master/static/lib/client.js#L18

[A Former User]

What is it? It haunts me.

Uncaught Error: Module name "csrf" has not been loaded yet for context: _. Use require([])
http://requirejs.org/docs/errors.html#notloaded