[nodebb-plugin-imgbed] Image Embedding with only a URL
-
Oh this is cool, I never realized that you actually fetch the image and save a copy to your server. So potentially you could do something like GitHub does (ie. host all images on your own CDN), so you don't have to worry about serving non-secure images from random sites when you're on SSL
-
@psychobunny said:
...so you don't have to worry about serving non-secure images from random sites when you're on SSL
Yep, exactly. Well that and I didn't like that an image takedown would make my forum look crappy.
@Albus are you referring to the upload capability or the imgurl capability?
-
-
I hadn't had the chance to look into any sort of integration with imgur, so sorry about that! If anyone wants to take a stab at that for now I would be paying attention to any pull requests
-
I found a bug, but when I headed over to GitHub the files are totally different so I'll tell you here...
Valid URL: http://oyster.ignimgs.com/wordpress/stg.ign.com/2014/09/TWDS5_2Sht_FM3_2.jpg?q=fhye
the above should work, but it doesn't due to the dots in stg.ign.com and the query string, I've changed the library.js file to be more liberal:
regexStr = '<a href="(https?://.+\.(' + extensions.join('|') + ')).*">[^<]*<\/a>';Should anyone else have this problem, then that'll work for you!
-
@kevin I've pushed the updates to github on my master branch if you need to get your hands on it ASAP, but I haven't tested the uploading part yet (which hasn't been published to npm yet, as it's still probably broken). Anywho basic parsing for images should work
-
@bitcalc said:
Valid URL: http://oyster.ignimgs.com/wordpress/stg.ign.com/2014/09/TWDS5_2Sht_FM3_2.jpg?q=fhye
the above should work, but it doesn't due to the dots in stg.ign.com and the query string, I've changed the library.js file to be more liberal:
regexStr = '<a href="(https?://.+\.(' + extensions.join('|') + ')).*">[^<]*<\/a>';Thanks, @bitcalc for finding that. I was trying to make the regex more efficient by not using the
.*pattern, but with urls like that, it might not be possible. Good find! -
@kevin Glad to hear it! I just pushed a pretty big update to npm, so you should be able to pull / install soon. It's a much cleaner approach, but it's still a little disabled in the fact that you can't specify your own extensions (yet, I still have to work out the saving settings part)
-
This plugin's admin panel has been broken for a while but I just fixed it this weekend along with some other improvements current version is now 0.2.0. Cheers!
-
Updated with package info to be visible in 0.8.x. Sorry about that oversight!
