uploads/picture.png stored in redis when uploaded, need uploads/picture.png instead

danBB

@baris Also when I upload a gif it stores it as a png

<baris>

@danBB There is a setting in admin section to turn images into pngs is that turned on?

danBB

@baris no its unchecked, and its only with gifs.

I also wasnt clear I ment that it uploads it to the directory as a gif but labels it as a png in the path string in redis

<baris>

Is this just for user profile images?

psychobunny

wooops, this is starting to sound like my fault.

edit: if the checkbox is off, this should leave your gifs as is (see my profile pic) - otherwise I guess its a bug

danBB

I think its a bug. Its still actually a gif when i look at it in the uploads folder, but the file path string stored in redis says its a png

<baris>

closes #706, refactor admin image uploads, fixed gif uploads · NodeBB/NodeBB@6c30437

Node.js based forum software built for the modern web - closes #706, refactor admin image uploads, fixed gif uploads · NodeBB/NodeBB@6c30437

GitHub (github.com)

Not sure if it resolved the gifs being stored as pngs problem. I couldn't reproduce that on my environment.

This should turn image links into relative links for all uploads (category images, favicon, sitelogo, user profile images).

I also noticed animated gif uploads totally broke. It was working at some point since both I and @psychobunny had animated gifs but if you try to upload an animated gif right now on this forum it won't show up. I figured out it was due to this

im.crop({
	srcPath: uploadPath,
	dstPath: uploadPath,
	width: 128,
	height: 128
}, function (err, stdout, stderr) {
	done(err);
});

After some googling and SO the following seems to work for cropping animated gifs .

im.convert([uploadPath, '-coalesce', '-repage', '0x0', '-crop', '128x128+0+0', '+repage', 'uploadPath'], function(err, stdout) {
	done(err);
});

Let me know if this resolves your issues.

danBB

@baris What about the original issue about the path that was stored in redis? its including localhost in the beginning of the path regardless of the image type

<baris>

Yeah that should be fixed with this commit.

Before it was storing http://yourdomain.com:4568/uploads/2-profileimg.png in redis. Now it should store /uploads/2-profileimg.png

danBB

@baris Perfect! Thanks for your help!