Username Mentions - Flood warnings?

[Chris]

Not sure where to put this - but I did a git pull tonight and my composer stopped working properly. After looking at the log I was geting flooding detected over and over.. After a process of elimination it seems to be related to the username mentions plugin?

I disable it and the issue goes away. I enable it and it comes back. I did this quite a few times.

19/11 13:06 [6842] - warn: Flooding detected! Calls : 11, Duration : 42
19/11 13:06 [6842] - warn: [socket.io] Too many emits! Disconnecting 4
19/11 13:06 [6842] - warn: Flooding detected! Calls : 11, Duration : 38
19/11 13:06 [6842] - warn: [socket.io] Too many emits! Disconnecting 4
19/11 13:06 [6842] - warn: Flooding detected! Calls : 11, Duration : 52
19/11 13:06 [6842] - warn: [socket.io] Too many emits! Disconnecting 4
19/11 13:06 [6842] - warn: Flooding detected! Calls : 11, Duration : 15
19/11 13:06 [6842] - warn: [socket.io] Too many emits! Disconnecting 4
19/11 13:06 [6842] - warn: Flooding detected! Calls : 11, Duration : 16
19/11 13:06 [6842] - warn: [socket.io] Too many emits! Disconnecting 4
19/11 13:06 [6842] - warn: Flooding detected! Calls : 11, Duration : 67
19/11 13:06 [6842] - warn: [socket.io] Too many emits! Disconnecting 4
[cluster] Restarting...

[Chris]

May or may not be a thing. I just got the same error when browsing a users profile. Not really sure what's going on, it's a forum that isn't even being used yet with only a couple of users and like four categories.

[baris]

Hey Chris, can you update to latest and let me know what message you get when this happens?

It is most likely related to what I did for https://github.com/NodeBB/NodeBB/issues/2432

barisusakli created this issue in NodeBB/NodeBB

closed socket.emit rate limitting #2432

[Chris]

@baris I updated about 5 minutes before that post.

[baris]

I just committed a change so you should git pull again. https://github.com/NodeBB/NodeBB/commit/6012223b81d1284a559dd6e421fc598507b3891e

Those warnings mean some client side code was making more than 10 socket.emit calls in less than 50ms and they get blocked by the new code. I want to know why there are so many socket.emit calls in the first place.

0 barisusakli committed to NodeBB/NodeBB

show message name, fix template name overwrite

[Chris]

Still getting the warnings and having issues with the composer not loading categories/letting me post.

19/11 19:51 [10307] - warn: Flooding detected! Calls : 11, Duration : 38
19/11 19:51 [10307] - warn: [socket.io] Too many emits! Disconnecting uid : 4. Message : user.getActiveUsers

[baris]

Are you using the forum stats widget? Are there more than one placed on the page?

[Chris]

I am - yes. And no, only the footer.

[baris]

Can you git pull again and npm install nodebb-widget-essentials@0.2.4. Don't forget to clear browser cache.

Let me know if you still get the flooding error.

[Chris]

@baris said:

npm install nodebb-widget-essentials@0.2.4

Yep, works now.