Bug? IE9 - reply, quote, chat etc buttons don't appear to work

julian

Looks like we'll have to fire up BrowserStack

a_5mith

Looks like we'll have to fire up BrowserStack

Good luck with that.

Browser testing service BrowserStack has temporarily suspended its services while it recovers from a "hack attack" by someone apparently bent on discrediting the security of the widely used tool.

Someone sent out an email last week claiming to be from browserstack claiming they were shutting down due to outright lies in their terms of service.

You can read the email here

julian

Hahahha oh right, I forgot about that. Not sure how much I believe in the claims, but still have to wait and see.

In the meantime, no logging in :shipit:

a_5mith

@julian Well they've confirmed they were hacked, but claim it was only email lists and their emailer (AWS I believe)

julian

Hm, can confirm that on IE9, the buttons don't work. Interesting...

kazr

Cool (sort of) - at least it's not just me

<baris>

Please try with https://github.com/NodeBB/NodeBB/commit/7a51520074d35577db201e8a881aeab03aa5797f and let us know.

kazr

Hi,

I've applied that commit (and the subsequent IE8 fix in the same if clause), and it appears to work: the buttons now work as expected, although we are seeing very odd socket.io behaviour (constant disconnect/reconnect) which I'm trying to track down, so I can't confirm this fixed 100%

Thanks for the fast turn around!

<baris>

Are you running nodebb in cluster? If so have you setup redis for socket.io?

kazr

No - just a single instance. I traced the socket.io problem to a plugin that'd been updated via npm to a version designed for 0.6.0 whereas we're running 0.5.4.
The nodeBB child process was constantly being restarted which manifested itself as constant reconnects on the clients.

pier

IE9 is broken again in 0.7.2 ?

PS: Just tried here too... regression confirmed

pier

Close-able, Mr Baris did the magic!