hook: filter:user.create firing when email is not available.

[agarcia17]

When an admin is creating a new user (with an email that is already taken) through the ACP, the hook "filter:user.create" is firing even though the error "[[error:email-taken]]" pops up. Was this intended or should the hook only fire if no errors occur?

P.S. If the passwords don't match and the admin clicks on the "create" button, the error "Passwords must match!" pops up and the hook is not fired.

[baris]

Good point I think that hook shouldn't fire at all if there are any errors, ie email is taken or its invalid etc.

[baris]

Should be fixed in https://github.com/NodeBB/NodeBB/commit/5be1c17aa7afbd5d9d9c9945f588b5630da3145e

0 barisusakli committed to NodeBB/NodeBB

refactor user.create

dont fire filter:user.create if there userData is invalid

[agarcia17]

@baris said:

Should be fixed in https://github.com/NodeBB/NodeBB/commit/5be1c17aa7afbd5d9d9c9945f588b5630da3145e

Thanks!