[nodebb-plugin-sso-github] Github SSO plugin

julian

Please keep in mind, all future SSO should be done through plugins.

The existing facebook, twitter, and g+ SSO options will become plugins at some point.

psychobunny

https://github.com/designcreateplay/NodeBB/commit/c16f04bbcf376217d74dddd9d0ce39d6695836e9

https://github.com/designcreateplay/NodeBB/commit/51b38c4c55da11191bdffc01f74b3756d709f79c

these are the two hooks of importance for the above plugin

omphalosskeptic

@psychobunny I’m new to NodeBB, and have just set up a forum. I’d like to use you plugin for GitHub auth, but have run into an issue:

When I click the save button, there’s no notification that it worked, and when I go back to the page, it seems to have gotten rid of my keys. I’ve tried restarting from the NodeBB dashboard and with rhc tools, but I haven’t gotten it to work.

After trying for a few times, I installed the google sso plugin and succeeded in getting Google auth working; it also removes the keys from the form, but it gives a save notification and seems to work.

Do you have any suggestions, or have I overlooked something ridiculously obvious?

Thanks!

julian

@omphalosskeptic Are you using the latest version of NodeBB?

omphalosskeptic

@julian Thanks for your reply. I’m running the latest stable version — 0.5.2 — installed using the Openshift tutorial from the docs. I’m using redis.

julian

Do you see any errors in the web inspector when navigating/saving the ACP? Is it just the plugins that have this problem, or are the general settings also not saving?

omphalosskeptic

@julian Ah, I don’t know why I didn’t think of that. When I go to the GitHub page under social authentication, I get Uncaught TypeError: Cannot read property 'prepare' of undefined from github:208 This doesn’t appear on the google page. Line 208 of admin.tpl seem to be

require(['forum/admin/settings'], function(Settings) {
    Settings.prepare();
});

Also, on all pages (including the homepage of the forum) I get Error during WebSocket handshake: Unexpected response code: 502, but that doesn’t seem to be the issue.

Thanks for your help.

julian

@omphalosskeptic Please install v0.2.0 of the GitHub SSO and give it a shot

omphalosskeptic

@julian Thanks very much for upgrading that. It works now!

julian

Glad to hear it!