URI malformed?

[a_5mith]

So, what's going on here then? Only just started happening, haven't updated or anything like that. I'm running my site through detectify which required me to add a meta tag. But I've removed it and it doesn't seem to have made a difference.

URIError: URI malformed
at decodeURIComponent (native)
at Object.Meta.title.build (/home/a_5mith/35hz/src/meta/title.js:17:28)
at Object.async.parallel.title (/home/a_5mith/35hz/src/middleware/middleware.js:320:17)
at /home/a_5mith/35hz/node_modules/async/lib/async.js:583:25
at /home/a_5mith/35hz/node_modules/async/lib/async.js:125:13
at Array.forEach (native)
at _each (/home/a_5mith/35hz/node_modules/async/lib/async.js:46:24)
at Object.async.each (/home/a_5mith/35hz/node_modules/async/lib/async.js:124:9)
at _parallel (/home/a_5mith/35hz/node_modules/async/lib/async.js:582:20)
at Object.async.parallel (/home/a_5mith/35hz/node_modules/async/lib/async.js:598:9)

[a_5mith]

@a_5mith Ok, so turns out it was Detectify crashing NodeBB testing different URL values. I've stopped it and all seems better.

[baris]

Looks like the decodeURIComponent on this line can crash with certain URLs. Probably happens when the URL has a % in it or its just %. More info.

[baris]

Added an error check for that function. https://github.com/NodeBB/NodeBB/commit/5696ea239633151d5adb6fade0dfa8b2d7805d7e

0 barisusakli committed to NodeBB/NodeBB

check errors on decodeURIComponent

[a_5mith]

@baris said:

Added an error check for that function. https://github.com/NodeBB/NodeBB/commit/5696ea239633151d5adb6fade0dfa8b2d7805d7e

Good stuff, cheers Baris, I will have another run at it with that commit at some point, see what caused it, the URLs did have % in them. So it was likely that. Have an upvote.