A question regarding my next plugin

julian

Is it up to date, and can I mess around with it?

Edit: I'm spending my morning uninstalling Apps from my phone because it's just unbearable now 3 minutes to open the keyboard? *REALLY?

a_5mith

@julian Yes, and yes.

julian

ಠ_ಠ

a_5mith

@julian I was going a bit psycho changing things until something worked.

julian

I think I know what went wrong... standby.

Edit: K, go for it: https://github.com/a5mith/nodebb-plugin-discogs/pull/2

a_5mith

@julian Sweet, thanks a lot Julian, only issue I've got left is the image(also in your screenshot), the api states that to get the image, you must authenticate yourelf.

I have a consumer key & secret which I believe is all I need, just not sure where to put them.

julian

@a_5mith I like their OAuth documentation

a_5mith

@julian They've recently redone the entire documentation, the bit in question is here

julian

There shouldn't be any need to funnel all requests into their OAuth flow, especially since you're doing this server-side. Is there any way for you to generate a token in the Discogs API settings, instead of having to step through and authorize yourself?

Just a moment...

(www.discogs.com)

a_5mith

@julian Apparently, you can change

http://api.discogs.com/image/R-90-5920911-1406378530-1731.jpeg

to http://s.pixogs.com/image/R-90-5920911-1406378530-1731.jpeg

And you get the correct image, but I'm not sure how that would be changed, as the API gives you the full URL.

julian

var imageUrl = whatever;
imageUrl.replace('api.discogs', 's.pixogs');

a_5mith

@julian Yes that would work.

a_5mith

@julian said:

var imageUrl = whatever;
imageUrl.replace('api.discogs', 's.pixogs');

Object #<Object> has no method 'replace'

I didn't actually use whatever, but it was either a not defined error, or this one. I also tried using things like

$('img[src="http://api.discogs.com"]').attr('src','http://s.pixogs.com');

But nothing changed.

julian

Sounds like the image url isn't actually a string... try typeof imageUrl to find out what it is.

a_5mith

@julian What do I do with that? We can't all be as smart as you Julian.

julian

Ah yes... compliments can only get you so far

var imageUrl = whatever;
// imageUrl.replace('api.discogs', 's.pixogs');
console.log('@@@@@ omgomgomg, the image is of type: ', typeof imageUrl);

It should be a string. It seems it isn't. Maybe it's an Array?

a_5mith

@julian Can I just clarify where the best place to put this is? Also, whatever; is undefined.

Ok, so I did

var imageUrl = [];
// imageUrl.replace('api.discogs', 's.pixogs');
console.log('@@@@@ omgomgomg, the image is of type: ', typeof imageUrl);

and it comes back as object.

Same if I do {}

Everything else comes back as undefined. I even tried worknowplskthx

julian

Mmm.. this is what I get back from discogs (it's in the albumData variable now):

{ style: [ 'Drum n Bass' ],
  thumb: 'http://api.discogs.com/image/R-90-3514574-1343107301-6843.jpeg',
  format: [ 'Vinyl', 'LP' ],
  country: 'UK, Europe & US',
  ...

So, you can get the image url: var imageUrl = albumData.thumb

... and replace it with the new CDN url: imageUrl = imageUrl.replace('api.discogs', 's.pixogs');

... or all-in-one: var imageUrl = albumData.thumb.replace('api.discogs', 's.pixogs');

a_5mith

@julian And where's the best place to add this? I'm getting albumData is undefined.

julian

albumData here? https://github.com/a5mith/nodebb-plugin-discogs/blob/579186035c9db7911ab230044a2bcdea5f4a32fa/index.js#L27

I don't know how much it has changed in the interim