NodeBB v4.0.0 Beta

sweetp

I get the following error trying to upgrade from v3.9.10 on my dev install:

4. Updating NodeBB data store schema...
Parsing upgrade scripts...
OK | 8 script(s) found, 145 skipped
  → [2024/2/22] Setting up default configs/privileges re: ActivityPub...Error occurred
Error occurred during upgrade: Error: [[error:invalid-data]]
    at Meta.slugTaken (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/meta/index.js:34:9)
    at Object.wrapperCallback [as slugTaken] (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/promisify.js:46:11)
    at generateHandle (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/categories/create.js:153:26)
    at Object.wrapperCallback [as generateHandle] (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/promisify.js:46:11)
    at /var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrades/4.0.0/activitypub_setup.js:25:36
    at Array.map (<anonymous>)
    at Object.method (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrades/4.0.0/activitypub_setup.js:23:42)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async Upgrade.process (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrade.js:161:4)
    at async Upgrade.run (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrade.js:110:2)

julian

@sweetp can you please add console.log(names); to line 22 (the blank line) in src/upgrade/4.0.0/activitypub_setup.js, and run ./nodebb upgrade activitypub_setup again?

sweetp

@Julian here you go:

Parsing upgrade scripts...
OK | 1 script(s) found
  → [2024/2/22] Setting up default configs/privileges re: ActivityPub...[
  { name: 'Cookie 7' },
  { name: 'TuneTag' },
  { name: 'Cookie 5' },
  { name: 'News' },
  { name: 'Minim' },
  { name: 'Cookie 4' },
  { name: 'ColorWell' },
  { name: 'Cookie 6' },
  { name: 'WiFiSpoof' },
  { name: 'SessionRestore JS' },
  { name: 'Privatus' },
  { name: 'USBclean' },
  { name: 'SessionRestore' },
  { name: 'Hides' },
  { name: 'Xliff Editor' },
  { name: 'Other apps' },
  { name: 'Invisible' },
  { name: 'Archived' },
  { name: 'Misc' },
  { name: null }
]
Error occurred
2024-10-03T18:18:47.515Z [4568/1713751] - error: uncaughtException: [[error:invalid-data]]
Error: [[error:invalid-data]]
    at Meta.slugTaken (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/meta/index.js:34:9)
    at Object.wrapperCallback [as slugTaken] (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/promisify.js:46:11)
    at generateHandle (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/categories/create.js:153:26)
    at Object.wrapperCallback [as generateHandle] (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/promisify.js:46:11)
    at /var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrades/4.0.0/activitypub_setup.js:25:36
    at Array.map (<anonymous>)
    at Object.method (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrades/4.0.0/activitypub_setup.js:23:42)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async Upgrade.process (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrade.js:161:4)
    at async Upgrade.runParticular (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrade.js:118:2) {"date":"Thu Oct 03 2024 20:18:47 GMT+0200 (Central European Summer Time)","error":{},"exception":true,"os":{"loadavg":[0.21,0.17,0.06],"uptime":2804105.47},"process":{"argv":["/opt/plesk/node/22/bin/node","/var/www/vhosts/domain.com/test.domain.com/NodeBB/nodebb","upgrade","activitypub_setup"],"cwd":"/var/www/vhosts/domain.com/test.domain.com/NodeBB","execPath":"/opt/plesk/node/22/bin/node","gid":1003,"memoryUsage":{"arrayBuffers":869789,"external":4802391,"heapTotal":92000256,"heapUsed":63868520,"rss":177631232},"pid":1713751,"uid":10011,"version":"v22.9.0"},"stack":"Error: [[error:invalid-data]]\n    at Meta.slugTaken (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/meta/index.js:34:9)\n    at Object.wrapperCallback [as slugTaken] (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/promisify.js:46:11)\n    at generateHandle (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/categories/create.js:153:26)\n    at Object.wrapperCallback [as generateHandle] (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/promisify.js:46:11)\n    at /var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrades/4.0.0/activitypub_setup.js:25:36\n    at Array.map (<anonymous>)\n    at Object.method (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrades/4.0.0/activitypub_setup.js:23:42)\n    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)\n    at async Upgrade.process (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrade.js:161:4)\n    at async Upgrade.runParticular (/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrade.js:118:2)","trace":[{"column":9,"file":"/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/meta/index.js","function":"Meta.slugTaken","line":34,"method":"slugTaken","native":false},{"column":11,"file":"/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/promisify.js","function":"Object.wrapperCallback [as slugTaken]","line":46,"method":"wrapperCallback [as slugTaken]","native":false},{"column":26,"file":"/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/categories/create.js","function":"generateHandle","line":153,"method":null,"native":false},{"column":11,"file":"/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/promisify.js","function":"Object.wrapperCallback [as generateHandle]","line":46,"method":"wrapperCallback [as generateHandle]","native":false},{"column":36,"file":"/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrades/4.0.0/activitypub_setup.js","function":null,"line":25,"method":null,"native":false},{"column":null,"file":null,"function":"Array.map","line":null,"method":"map","native":false},{"column":42,"file":"/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrades/4.0.0/activitypub_setup.js","function":"Object.method","line":23,"method":"method","native":false},{"column":5,"file":"node:internal/process/task_queues","function":"process.processTicksAndRejections","line":105,"method":"processTicksAndRejections","native":false},{"column":4,"file":"/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrade.js","function":"async Upgrade.process","line":161,"method":"process","native":false},{"column":2,"file":"/var/www/vhosts/domain.com/test.domain.com/NodeBB/src/upgrade.js","function":"async Upgrade.runParticular","line":118,"method":"runParticular","native":false}]}
$

julian

@sweetp what is the last category, and how come it has no name?

sweetp

@Julian Im not sure, is there any way to purge it?

julian

@sweetp does it correspond to an existing category? Or are all of your categories represented in the output above?

sweetp

@Julian all my categories are repesented by the log output

sweetp

@Julian I filtered out the null names and the upgrade went through:

"use strict";

const db = require("../../database");
const meta = require("../../meta");
const categories = require("../../categories");
const slugify = require("../../slugify");

module.exports = {
  name: "Setting up default configs/privileges re: ActivityPub",
  timestamp: Date.UTC(2024, 1, 22),
  method: async () => {
    // Disable ActivityPub (upgraded installs have to opt-in to AP)
    meta.configs.set("activitypubEnabled", 0);

    // Set default privileges for world category
    const install = require("../../install");
    await install.giveWorldPrivileges();

    // Run through all categories and ensure their slugs are unique (incl. users/groups too)
    const cids = await db.getSortedSetMembers("categories:cid");
    const names = await db.getObjectsFields(
      cids.map((cid) => `category:${cid}`),
      cids.map(() => "name"),
    );

    const nullIndexes = names
      .map((element, index) => (element["name"] === null ? index : -1)) // mark null elements
      .filter((index) => index !== -1);

    let filteredNames = names.filter(element => element["name"] !== null);
    let filteredCids = cids.filter((_, index) => !nullIndexes.includes(index));

    const handles = await Promise.all(
      filteredCids.map(async (cid, idx) => {
        const { name } = filteredNames[idx];
        const handle = await categories.generateHandle(slugify(name));
        return handle;
      }),
    );

    await Promise.all([
      db.setObjectBulk(
        filteredCids.map((cid, idx) => [`category:${cid}`, { handle: handles[idx] }]),
      ),
      db.sortedSetAdd("categoryhandle:cid", filteredCids, handles),
    ]);
  },
};

[email protected]

I’ve been playing around with community.nodebb.org, in anticipation of 4.0’s launch, and I’ve noticed that the Lemmy groups I’ve followed don’t appear to be showing up. I can see posts from Mastodon (and whatever else) users that I’ve followed in World, but not Lemmy groups.

Is this expected or intended? Following nodeBB topics from Lemmy has worked OK, so I thought it would be bidirectional.

Though, now that I’m comparing this post on lemmy.ca to that on the mothership, I see that replies from nodebb.org users aren’t showing up on the remote instance, either. Just those from off-site users. I’m caught somewhat off guard by that, too. Is that behaviour expected?

julian

@[email protected] whether replies from here appear on lemmy.ca depends on whether a user from lemmy.ca follows a user here. Perhaps that isn't the case? (Hopefully you see this reply now )

Still need to debug Lemmy federation. Might be a regression.