editing in quick reply + k-key

[murcs]

is there any known issue with the k-key while editing in quick reply?  users at our site experience a kind of jump one or more posts up while typing the k-key.  our forum runs v2.8.4.  it happens while using firefox on windows 10 or ubuntu 20.04 on a desktop device or safari on iOS 16.3 on an iPhone or edge on windows 10 or ...  could not find any report using the search function.

[baris]

Sounds like the keys to navigate posts is causing it? Does it happen on this forum? https://github.com/NodeBB/NodeBB/blob/master/public/src/client/topic.js#L91-L107

[murcs]

@baris said in editing in quick reply + k-key:

Does it happen on this forum?

no.  our forum runs v2.8.4 as already mentioned with the persona theme v12.1.12.  maybe the theme has some influences.  ... or one of the plugins we use.  but at least on mobile shortcuts should be disabled, shouldn’t they?

[baris]

I think this commit fixes the issue but it is on the bootstrap5 branch https://github.com/NodeBB/NodeBB/commit/5c9fe6c0fd48988dc6303d9551f9d99145a8db95 @julian

[julian]

Yeah that commit will fix it. You can cherry-pick that commit in if needed.

git fetch
git cherry-pick --no-commit 5c9fe6c0fd48988dc6303d9551f9d99145a8db95

[murcs]

hej @baris and @julian .

we decided to stay with the normal releases for some reasons and waited for a version newer than v2.8.6 but the k-/j-issue in quick reply isn’t fixed in the latest v2.8.7 ... any idea why?

thanks.

[baris]

I've added this into master will be available in 2.8.8

[murcs]

dear @baris thanks for the release of v2.8.8 ... our users a very happy!