Shared ESlint config

Antosik

Hey!

Should we create a eslint-config-nodebb that will encapsulate the existing ESLint config from core (public and lib)?

So we will use this like

{
    extends: "eslint-config-nodebb/server"
}

or

{
    extends: "eslint-config-nodebb/client"
}

This will help to unify the code style among plugins and core.

P.S. Need to discuss the naming of the packages

<baris>

This sounds like a good idea, since we end up copying the core config to plugins and any changes in the core config doesn't propagate to the plugins.

Antosik

@baris, so, what are the next steps?

We need to create https://github.com/nodebb/eslint-config-nodebb repository
Discuss the naming for server/client side configs (client/server, or lib/public, or smth else)
Need to copy the existing configs and create a shareable according to docs
Publish it at npm

julian

@antosik We have a separate config for client-side... is it possible to host that in an extendable package as well?

Antosik

@julian Yep, you can define multiple configs in one package - take a look at Sharing Multiple Configs

julian

@antosik Let's get this done. Feel free to PM me

<baris>