No footer.js in v16.1.x?

[Teemberland]

Hi, I just upgraded from v.14.x to v.16.1 and found a browser error after rebuilding my forum. Here's the snippet of the error:

Uncaught Error: Script error for "forum/footer"
https://requirejs.org/docs/errors.html#scripterror
    makeError require.js:168
    onScriptError require.js:1738
    load require.js:1943
    load require.js:1685
    load require.js:834
    fetch require.js:824
    check require.js:856
    enable require.js:1176
    enable require.js:1557
    enable require.js:1161
    bind require.js:134
    each require.js:59
    enable require.js:1113
    init require.js:788
    o require.js:1460
    setTimeout handler*req.nextTick< require.js:1815
    o require.js:1449
    requirejs require.js:1797
    <anonymous> (index):876
    EventListener.handleEvent* (index):875
require.js:168:16

I looked into my old install and found footer.js in public/src/client.

My question is, is footer.js is still required? If not, how can resolve the browser error above? Thanks!

[baris]

Which theme are you using? footer.js is no longer necessary in latest versions. It was removed from persona theme https://github.com/NodeBB/nodebb-theme-persona/commit/4dcc9fad23eed806604397292a2d8117f1052320.

Mostly likely your theme is out of date.

0 barisusakli committed to NodeBB/nodebb-theme-persona

feat: move footer scripts to core partial

[Teemberland]

@baris said in No footer.js in v16.1.x?:

Which theme are you using? footer.js is no longer necessary in latest versions. It was removed from persona theme https://github.com/NodeBB/nodebb-theme-persona/commit/4dcc9fad23eed806604397292a2d8117f1052320.

Mostly likely your theme is out of date.

I will double check this with my colleague. I believe we're using a custom theme based on Persona.

Since the theme is custom, does that mean we have to remove all dependencies for footer.js to fix the error?

[baris]

Yes, apply the changes from the above commit. If you custom theme doesn't make any modifications to footer.tpl then you can delete it and the one from persona will be used.

The latest footer.tpl is here

[Teemberland]

EDIT:

@baris error is gone / fixed. Thank you!