NodeBB v1.13.3 released!

[Eda]

Hello folks!

We've released a new patch v1.13.3. For closed issues, please check our GitHub page:
https://github.com/NodeBB/NodeBB/issues?q=is%3Aissue+milestone%3A1.13.3+is%3Aclosed

Cheers!

[sweetp]

I get an update error

4. Updating NodeBB data store schema...
Parsing upgrade scripts... 
OK | 1 script(s) found, 83 skipped
  → [2020/5/2] Fix user sorted sets...
    [######       ] (500/1021) 48% (node:14753) UnhandledPromiseRejectionWarning: error: null value in column "score" violates not-null constraint
    at Connection.parseE (/var/www/vhosts/website.com/NodeBB/node_modules/pg/lib/connection.js:581:48)
    at Connection.parseMessage (/var/www/vhosts/website.com/NodeBB/node_modules/pg/lib/connection.js:380:19)
    at Socket.<anonymous> (/var/www/vhosts/website.com/NodeBB/node_modules/pg/lib/connection.js:116:22)
    at Socket.emit (events.js:198:13)
    at addChunk (_stream_readable.js:288:12)
    at readableAddChunk (_stream_readable.js:269:11)
    at Socket.Readable.push (_stream_readable.js:224:10)
    at TCP.onStreamRead [as onread] (internal/stream_base_commons.js:94:17)
(node:14753) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:14753) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code

[sweetp]

fixed with the following patch:
https://github.com/NodeBB/NodeBB/commit/6a5e86dc667a42009bcac0c7061a21b6717cf9a9

[James King]

Currently getting the following error when doing a large update.. 1.8.x -> 1.13.x

[2019/4/5] Update moderation notes to hashes...
    [              ] (100/185135) 0% Error occurred
Error occurred during upgrade: TypeError: Cannot create property 'timestamp' on number '1494309356813'

Any idea what might be causing this? - other than the fact that a number obviously won't have a timestamp property

Thanks

[jag]

This post is deleted!

[baris]

@James-King said in NodeBB v1.13.3 released!:

Update moderation notes to hashes

Looks like you have same invalid notes in the db, can you run this command in mongodb

db.objects.find({_key: /^uid:\d+:moderation:notes$/}).sort({score: -1}).limit(100);

[James King]

Hi @baris

Thanks for the reply. We're on Redis here instead of Mongo. Sorry, I should have specified.
I did the same thing in Redis, It appears that we had a lot of "blank" notes which were just timestamps - I've removed these (or rather, I converted them over to objects with a timestamp property) and it appears to have resolved this for now.

Not sure going by the timestamps exactly what caused these notes to be added however, but I didn't want to lose the fact that something happened at that point.

Thanks for the guideance