Yeah these are jQuery/bootstrap errors, only happens in FF, and unfortunately not something that will be fixed unless we migrate to the latest jQuery (which also means we'd have to drop support for IE8). Not a big deal imo, it doesn't affect anything aside from annoy me a little when I'm debugging code
Facebook policy warning
-
Today I received this email:
nodeBB: v.1.11.2
nodebb-plugin-sso-facebook: v3.4.2What means exactly? Seam something with facebook sso plugin?
Thanks
-
It probably means they don't like the facebook button you use for SSO login. Google does similar things.
As a quick workaround, you can use custom JS to replace the login button with the appropriate "Login with Facebook" button.
-
Thanks @julian . We have the same alternative login as you. So I suspect you will receive the same email from facebook too.
-
Well, I think found one issue. The facebook loggind button has a transparent "f" and on you default theme looks like right, but with default dark theme looks wrong.
Your forum:
Our forum:
Any workaround for this issue?
-
@Normando I'll be doing a review of SSO plugins in the next few days so I'll handle this issue then.
-
@Normando Please try v3.5.0 and re-submit to Facebook, let me know if this is acceptable!
-
I will do right now, and tell you the reply from Facebook. Thanks Julian.
-
Let's hope so. Facebook's branding guidelines are a lot less stringent than Google's, but either way, I ended up using their logo asset and stylized the button with copy as recommended.
If I had to guess, I think their complaint was that FontAwesome wasn't using the right "Facebook Blue". That might've been enough, but I didn't see any harm in making a nicer looking button.
-
Nice job @julian , this is the FB reply. Of course I need to fix Privacy Policy too, but the button is OK!!!
