[nodebb-plugin-spoilers] Spoiler text in posts

a_5mith

@pwFoo hover is implemented on mobiles as the first click. Android will usually show the hover whilst the page is loading, because important info shouldnt be hidden in on:hover events, iOS do it differently, iOS count a hover event as one tap, then make you tap again to access the page.

I will look into this later, see what can be done through CSS.

pwFoo

@a_5mith
Works fine with my Android Nexus 5. If at desktop browsers behavior could be changes from hover to click easily would be a nice option.
But I also can live with hover to view at desktop

art

It's really nice. Does the image load via ajax?

It would be nice to have something like this just to deal with large images. Some forum pages you go to, people have posted a million giant images and you can sit there for an hour while the page loads. If you're on mobile, forget about it.

Either completely hide the image and load via ajax. OR show a thumbnail and then load via ajax over hover or click.

Just a thought, probably for another plugin.

a_5mith

@art some sort of lazy loading library would be good for this, I'm currently working on lazy loading all the media on my site via different libraries, as I'm not skilled in rolling my own.

So far I've got YouTube videos done, but still working on soundcloud, mixcloud, hearthis.at, webm files and normal images/gifs.

bitcalc

@psychobunny said:

0.0.3 - updated to add a button in composer to add spoiler text.

my icon disappeared recently

shinyidol

Just updated to 0.5.2 and text just comes up as quoted now.

esiao

@shinyidol if you're using nodebb-buttons-galore update to the latest. There was a conflict between the two Plugins.

glitch

! test

I don't think I understand how this is supposed to work. To me, spoiler text means text that is hidden without action taken. If that's what this plugin is supposed to do, could I please be told the correct way to do it?

a_5mith

@glitch said:

! test

I don't think I understand how this is supposed to work. To me, spoiler text means text that is hidden without action taken. If that's what this plugin is supposed to do, could I please be told the correct way to do it?

Plugin isn't installed here.

glitch

...

I suppose that would help, thanks. On my own installation, however, I get the same results. I know the plugin is installed because I see the little crossed out eye in the markdown editor. It renders just like my test example here, though.

esiao

Seems like the plugin is broken on NodeBB 0.6.0
As stated here by @Ted
https://github.com/psychobunny/nodebb-plugin-spoilers/issues/3

a_5mith

Seems @psychobunny needs to start merging commits instead of sitting on Reddit/r/procrastination.

psychobunny

haha derp. You know its bad when I get three PR's doing roughly the same thing. Anyways merged and published, thanks guys

esiao

@psychobunny I should have a plugin conflict because it doensn't seems to be solved on my board (plugin updated)

zay

i build this plugin with my version

*its not same or copy your plugin i just see how it work for notbb v.0.6

thanks for inspiration

i build with function toggle down and up

phl

Does the plugin still work in a recent nodebb installation?
If yes, do multiline spoilers generally work?
I am getting exclamation marks at the start of a line after an empty line has been used in the spoiler text. It seems that the parsing somehow won't work correctly.

Toda

teat! sorry

Bri

@phl if I understood what you were saying, that's typically how markdown works; a blank line will stop rendering the text in the same block.

> here's a quote
With a new line

After a broken line

Will produce:

here's a quote
With a new line

After a broken line

a_5mith

Your new line will need a spoiler tag too to be included.

I think.

phl

Well that's of course what I tried. Every possible combination of spoiler tags I could imagine (At the start of text blocks, in every line, in a new line, ...)

While

> citation
more citation
>
> even more citation

renders as expected,

>! Spoiler
more Spoiler
>!
>! even more Spoiler

produces visible exclamation marks in the output at lines three and four.