Fix spoiler plugin

Master

Hi!

Images in spoiler dont show up. I would be grateful for help.

GitHub - NicolasSiver/nodebb-plugin-ns-spoiler: Spoiler. Ability to control visibility of the content in posts. Works better with Markdown syntax.

Spoiler. Ability to control visibility of the content in posts. Works better with Markdown syntax. - NicolasSiver/nodebb-plugin-ns-spoiler

GitHub (github.com)

spoiler.js:57 Uncaught TypeError: e.unloadImages is not a function
    at i.<anonymous> (spoiler.js:57)
    at i.onack (socket.io.js:2)
    at i.onpacket (socket.io.js:2)
    at i.<anonymous> (socket.io.js:2)
    at i.emit (socket.io.js:1)
    at i.ondecoded (socket.io.js:1)
    at a.<anonymous> (socket.io.js:2)
    at a.i.emit (socket.io.js:1)
    at a.add (socket.io.js:1)
    at i.ondata (socket.io.js:1)

Master

Bump topic

<baris>

What version of core? That function is defined in NodeBB core.

Master

@baris 1.8.2, all people who is using this plugin have this problem.

When i was at 1.5.x plugin works correctly.

Brophy

Have you tried the 'nodebb-plugin-btn-spoilers' plugin? That's working on my 1.8.2 install.

Master

@brophy No i havent tried yet but this plugin have diffrent tags. Its a problem for my old posts.

Master

Bump topic

Dravere

I doubt that this worked with 1.5.x. But it might have worked with 1.4.x. There was a breaking change between those minor versions on the client side. The function unloadImages moved from the module forum/topic/posts to forum/topic/images. This plugin basically is now incompatible with the current NodeBB and needs fixing.

Master

@dravere Sorry, it worked on 1.4.x. Will anyone fix this plugin?

Dravere

You'll have to ask the author of the plugin. Best is you open an issue on the GitHub repository and hope you'll get an answer: https://github.com/NicolasSiver/nodebb-plugin-ns-spoiler/issues

Master

@dravere Done https://github.com/NicolasSiver/nodebb-plugin-ns-spoiler/issues/13

Master

Plugin fixed by author.

julian

Nice, thanks @nicolas!