@baris Guess that should have been the obvious, and yeah, we had some code that would auto generate a background for users. Disabling that did fix it. I really appreciate the help, feel kind of stupid now lol. Besides that being fixed now we still have an ongoing issue with plugins not working like emoji's, shoutbox, and so on. And words of advice on that?
Hey dudes i just took down your site for seconds with a simple bash command
poked around your codebase a little... I had no idea forEach was so slow!
Anywho, run this:
while true; do curl http://try.nodebb.org/bench/forloop; done &
3 times or so from bash and goodbye try.nodebb.org.
also write more unit tests!
also since I pointed this out, could I put a feature request in for a classic theme? something that looks like vBulletin or so with similar formatting/pagination and whatnot.
also eliminate the tab character from your codebase. jesus.
About to head to bed, so I'll make this quick and reply properly tomorrow:
Thanks for finding this little gem! @baris initially wrote it to see what was faster, forEach, or for loops. It should've been removed a long long time ago, so I have no idea why it's still in the repo. In any case, it's gone now.
@psychobunny has more information re: vanilla themes and theming
The entire team is very behind tab indentation, and I honestly don't see us switching to space-indentation overnight. Besides, we could argue for and against tab vs. space all night long, and it wouldn't solve anything...
That seemed like a pretty proper reply to me, except you're like so wrong about tabs: you want your code readable no matter what tab stops are set to, and that becomes just too difficult to do with tabs (esp. if you're using emacs). I suspect you'll end up agreeing over time, especially if you ever work on a more than 3 person project.
also, I think you should do input type validation in your websocket code. I think my website is currently set to an object and not string...
I'll stop poking around now. Good luck!