Problems with nodebb-plugin-blog-comments

[jdp23]

Hi there, I set up a new nodebb installation following the "for dummies" instructions, and it seemed to work, although I got a few warnings that plugins may not be compatible with my version of nodebb. Then I installed the blog comments plugin and started getting this error message:

error: [app] Encountered Uncaught Exception: Cannot call method 'toString' of undefined
TypeError: Cannot call method 'toString' of undefined
at /home/tapestrymaker/NodeBB/node_modules/nodebb-plugin-blog-comments/library.js:151:29
at fs.js:207:20
at Object.oncomplete (fs.js:107:15)
error: [app] Could not restart server. Shutting down.

Suggestions?

[Scuzz]

@jdp23 There seems to be a lot of incompatible plugins and versions of NodeBB at the moment. It might be best waiting for the 0.4 release and for the plugins to be updated before installing any more.

[finid]

@Scuzz

The real problem is that every new install is git-pull-ing Edge, and not 0.3.2, even though it reports in the ACP that NodeBB is 0.3.2. We just need a way for new installations to get the latest stable version, not Edge.

[julian]

blog-comments was working with the latest Edge version, although it's possible a recent commit broke it... @psychobunny ?

[finid]

@julian

And because a recent commit has the tendency to break any number of things is a good reason why new installations should not be grabbing Edge.

[julian]

@planner Agreed, but given the way sometimes edge versions break backwards compatibility (especially with 0.4.0, patch versions shouldn't exhibit this problem), plugins updated to the latest version are liable to break on older versions too!

problems problems...

[Scuzz]

@planner if you switch to the branch for 0.3.x then a git pull shouldnt change unless that branch is up to date. Obviously if you are on a master branch then you will pull the lastest changes to that branch.

[jdp23]

Thanks all. After pulling the latest version from git and upgrading the plugin (now v 0.1.19) I still get a warning about

warn: [plugins/nodebb-plugin-blog-comments] Hook method mismatch: filter:server.create_routes => addRoute

but it seems to restart properly. I'll let you know how the attempt to use the plugin goes.

It sounds like I would have been better off installing the 0.3.2 branch and the versions of the plugins that are known to work with that branch. I know it's still early days with the software but for those of us who are interested in kicking the tires, it'd be great if the "dummies" instructions led me to a stable version with working plugins, and then described the "edge" instructions setting expectations appropriately. [Yeah, yeah, I know, easy to say ]

[psychobunny]

I might just go and update that guide at some point We just finished updating almost all of our plugins to 0.4x, and I don't see ourselves having to do that again (because there was a pretty massive overhaul in the codebase en route). So you should be relatively safe with Edge right now (or just wait for 0.4x to be released... very soon)

[jdp23]

Sigh, no joy. I'm not getting the Blog Comments section in the ACP.

Not sure if this is related but I'm getting a message in the Dashboard "A new version (v0.4.0) has been released. Consider upgrading your NodeBB." But after doing a ./nodebb/upgrade, I'm still on v 0.3.2.

[psychobunny]

You would have to git pull to the latest before upgrading. If you're on the 0.3x branch you'll also have to switch to 0.4x or master first

edit: actually hold the boat, think I found an issue with my latest update of blog comments

[jdp23]

OK, the boat is held -- thanks for letting me know!

[psychobunny]

Okay, I found the issue causing it to not show up on the previous version. Update to blog comments 0.0.21, and you'd need to be fairly latest on NodeBB as well (or just switch over to 0.4x/master and pull latest)

[julian]

The Blog Comments Plugin on Launch Day

[psychobunny]

rofl! yeah that would be twice that my plugin's been screwed on launch

[jdp23]

Major progress! I'm now able to configure the Blog Comments plugin, and I see the "Publish" button on my blog. Yay! But, when I click on it I get a 404. Looking at the http log on the server side, it seems to be in response to POST /comments/publish ...

[jdp23]

Aha, but if I add

app.post('/comments/publish', Comments.publishArticle);

to Comments.init, it works! Reply is still getting a 404, probably the same deal ...

Still, I would say the boat is now floating!

[psychobunny]

Ah, please update to 0.0.22

Edit: Looks like you figured out the problem yourself

Edit2: Sorry for making you my guinea pig, I was waiting for us to publish the 0.4x release blog post before actually testing my changes

[jdp23]

Yepper, 0.22 solves it. Thanks!

And no worries, I really appreciate you taking the time to look at it while you're in the midst of launching! Plus I get to feel good about my node sk1!!z

[psychobunny]

haha yup. Next time I'm just going to let you handle it yourself