[nodebb-plugin-adsense] Google Adsense

dove

@planner

@planner said:

@dove
If you have the time to make it a comprehensive ad plugin, here are a few suggestions:

In the ACP, provide Location boxes for ads such that ad codes can be copies there.

Locations could be for header, footer, left of post, right of post, middle of post, bottom of post, etc.

Sure I might find some free time next week and make it

finid

@dove

Great, looking forward to it.

julian

@dove Awesome work! We have our own, although it is horribly outdated -- glad you took up the effort to make your own

finid

Wondering what the ACP page for this plugin looks like, here's a screenshot.

julian

Thanks @planner -- I think we can safely deprecate the original adsense plugin by @psychobunny

finid

@julian

Is that how much confidence you have in @psychobunny? If I were him, I'd come after you or just send the major of Toronto to pay you a visit.

But seriously, this is a very good plugin. It just needs to be made generic, so it can handle any display ad provider.

finid

@dove,

So I installed the plugin, but have not specified my Google AdSense id or any specific ad id in the ACP. But that didn't stop Google Ads from showing at the end of every post on my site. Image below. I'm assuming the ads are running with your AdSense id. That right?

finid

Now the ads stopped showing, only showing the default ad I mentioned in the post above. Buggy?

dove

@planner I noticed it now, there was wrong letter in if case check, so it shows ad in post even if disabled. But the most strange part is that google shows ads even without publisher ID and campagn ID specified, so I wonder who gets money for click ? Probably Google
Will update it sometime today.

finid

But the most strange part is that google shows ads even without publisher ID and campagn ID specified, so I wonder who gets money for click ? Probably Google

@dove

Yeah, I was wondering about that too. I checked the code and I did not see any publisher ID in it. The Evil Empire has to make money any way it can.

One other thing you might want to take a look at: My ads stopped showing and now only shows the default ads from Google, even with my publisher ID specified. The most VIP thing to do, of course, would be to make it possible to use generic ad codes in there.

psychobunny

Nice work @dove totally destroyed my original plugin but this is good, one less plugin for me to have to update for 0.4x

I think a lot of people would find this useful. Thanks!

dove

Had a few free mins again, so updated plugin.

Fixed bug when ad in post was displayed even if disabled in admin panel;
Made responsive height ad in post when enabled left or right position. For a short post ad will be 250x250 size, and for large post it will auto resize vertically to max of 600px.

dove

@psychobunny said:

Nice work @dove totally destroyed my original plugin but this is good, one less plugin for me to have to update for 0.4x

I think a lot of people would find this useful. Thanks!

Haha, I saw your plugin, but I also saw this message "This plugin has been superceded by NodeBB's Widgets System, available as of v0.4.x.", so I thought that your probably won't update it any more

finid

@dove

Awesome and thank you very much. Looking forward to the next feature upgrade - making it ad provider agnostic

finid

pinging @dove, the plugin is still not working properly. My ads are no longer showing. Only the default ad from Google is showing.

dove

@planner Did you try to clear your cache?

finid

@dove

Yes, I did. Some times it works, that is, shows my ads. Other times, it doesn't and shows a default ad. Perhaps we need a button on the ACP to clear the cache server-side.

Right now, it looks like I have to clear the cache on every single page before the proper ad shows.

dove

@planner
Hm, Are you really running latest version? It should be 0.0.4. Because I have exactly same plugin installed here http://manutdforums.com it is working for me, can you check if it is working for you too?
Edit: Try reinstalling plugin completely with npm remove nodebb-plugin-google-adsense and then npm install nodebb-plugin-google-adsense

finid

@dove

@dove, do you have the time to apply the solution suggested by @bentael here to the plugin, that is,, the use of action:ajaxifying, action:ajaxified, and action:page.load, so that the ads will load on every user activity. Right now the ads show only on browser refresh.

igbuend

Small request: can you leave out the "http:" in the ad-sense URL in main.js? Now some browsers get a security warning when the forum is running with HTTPS. If you leave out the protocol, the browser will automatically user HTTP or HTTPS depending on what was used to load the page with the ad-sense link.

Thanks a lot!.