Changes to Lavender theme - few issues.

Moved NodeBB Development
  • HI guys, I really like the Lavender theme, so have decided to modify it. One issue I'm having is with embeds appearing on the forum home page. I have the soundcloud embed tool active on a forum where people post mixes.

    In home.tpl file:


    The issue I'm having is that the embed is adding it's own paragraph tags. This causes the rest of the thread (the tracklisting) to fall outside of the paragraph tags inside home.tpl, and as such the max-height class associate with .post-preview p {} doesn't apply, I've looked in the soundcloud plugin, and it only adds the iframe from what I can see, so something else must be adding the paragraph tags.

    In addition, is there anyway to actually have the soundcloud widget embed on this homescreen, rather than just showing the URL? 馃檪 Or any other alternatives?

  • The paragraph tags probably come from the markdown plugin -- the order in which the post.parse filter is applied:

    1. Markdown
    2. Embed plugins

    So markdown sees the raw url, and adds <p> tags around it, and then the embed plugin turns it into the <iframe... code.

    If it's bleeding through the container, have you tried setting wmode on the container to opaque? Not sure if that would do it...

  • Hey @julian

    I can confirm it is something in the essentials plugins pack that's causing it. I've tried a few changes, but nothing I've done has helped. Everything after the embedded iframe falls outside of p tags, so I can't do anything with it.

    From what I can work out, my options are to either stop the markdown from wrapping the raw URL in <p> tags. Or I add {categories.slug} to the div class and create a custom css rule for the mixes recent posts to not show the preview on the homepage. 2nd option sounds easy enough, but the 1st would be preferred.

    I should really learn markdown. I'm struggling to do anything. 馃槅 I'm so used to BBcode coming from SMF.

  • Can you post a screenshot of what happens when you try embedding video on a home page?

  • HI @julian,

    I have attached the screenshot below, the mixes category is the one that's causing me issues. I have also included the raw HTML below so you can see how it's affecting the p tags. General discussion is how it should look. Ideally with the soundcloud embedded. But that's another issue I can deal with later.

Suggested Topics

  • 2 Votes
    5 Posts
  • 0 Votes
    3 Posts
  • 0 Votes
    5 Posts
  • Mixing up themes

    Moved NodeBB Development
    0 Votes
    2 Posts
  • 1 Votes
    6 Posts